musicbrainz-server icon indicating copy to clipboard operation
musicbrainz-server copied to clipboard

Published 20 hours ago • verified publisher icon metabrainz

MBS-12552 (V): Refactor JS code for central entity

Open yvanzo opened this issue 2 years ago • 2 comments

Problem MBS-12552

The term “core” has been used so far with different meanings (some entities, public domain data, search indexes).

Solution

Following the pulll request #2731, it replaces this term with "central" in JavaScript code.

Checklist for author

  • [ ] Check that other instances of core entities in the repository are for public domain data/entity/table only.
    • [ ] Decide whether or not to rename “Core entities” in statistics

Action

  1. Update WikiDocs accordingly

yvanzo avatar Nov 14 '22 15:11 yvanzo

For reference, the discussion about the term “Central” continued in comment to the ticket.

The logic would be to review the pull request https://github.com/metabrainz/musicbrainz-server/pull/2731 first since it is ready and it precedes this one (which is a draft) as mentioned in the top-level comment. (Restored the intentionally nested items of the checklist.)

yvanzo avatar Nov 15 '22 17:11 yvanzo

Rebased, amended and merged the 5 first commits unto the pull request https://github.com/metabrainz/musicbrainz-server/pull/2885. We will advise the renaming to Central only if needed after we have refined as many occurrences of CoreEntityT to more adjusted types as possible.

yvanzo avatar Mar 07 '23 16:03 yvanzo