musicbrainz-server icon indicating copy to clipboard operation
musicbrainz-server copied to clipboard

MBS-1658 (implementation): Add collection comment to collection lists

Open reosarevok opened this issue 3 years ago • 10 comments

Implement MBS-1658

This allows setting and displaying collection comments from the main page for a collection. While we will eventually probably want to also allow setting the comment while adding the entity to the collection, this seems like a pretty useful start.

Since the comment is just added via ws/js, it should be easy to also call that endpoint on addition once we come up with a sensible UI to do so.

Tested:

  • Adding / editing comments to my own collections (including RG since that has extra layers)
  • Adding / editing comments on collections I collaborate on
  • Viewing comments in public collections (and that empty comments are not shown)

Peek 2023-01-12 15-36

reosarevok avatar Apr 12 '21 08:04 reosarevok

Not sure about submitting the comment by blurring the textarea - an actual "submit" button next to the field might be more obvious/usable?

IIRC we talked about this back in the day and you liked this option :D But I'm not against a submit button either. What would happen on blur in that case? Nothing? If so then we'd need a cancel button too probably because submitting to change nothing just seems weird. I guess an option would be that it detects if it's changed and shows "Cancel" or "Submit" appropriately, as well?

reosarevok avatar Jul 26 '22 19:07 reosarevok

Hmm, it’s not making me scream, but I don’t know about adding a ‘Add Comment’ line to every item. Seems very busy if you’re not interested in adding comments.

Hate to get all column heavy, but seems like another column might be better… with the header ‘Comments’ and then ‘Edit’ in each row (no pencil icon please)

Aerozol avatar Jan 15 '23 09:01 Aerozol

IIRC we did it this way because most collection types already have ridiculous amounts of columns. Ideally I guess we'd have a way to filter those so that you don't need to show all the columns when you don't need them, but that's a lot of work 😅

reosarevok avatar Jan 15 '23 09:01 reosarevok

Definitely a lot of columns… but if anything I would take others out to make room for the comment column, or group some others together. No perfect solution, but some of those other columns are surely not used as often.

My mockups for the redesign have custom columns but I also though “wow glad I don’t have to code this” ;)

Aerozol avatar Jan 15 '23 10:01 Aerozol

The extra line below the entity name doesn't seem too bad considering that (for example) label disambiguations are so long that each line takes up a lot of space already anyway. Of course, hiding or grouping columns might be another solution.

Either way, would love to have this added eventually, was just about to request this on the issue tracker earlier.

Maxr1998 avatar Jun 17 '23 08:06 Maxr1998

I can't wait for this feature! It will be an absolute game changer for keeping notes against stuff in MusicBrainz.

elliotchance avatar Sep 03 '23 20:09 elliotchance

@reosarevok what's holding this up?

elliotchance avatar Nov 30 '23 05:11 elliotchance

Mostly the same thing that's holding most PRs back - there's just too many and the team cannot find time to go through the backlog :/

reosarevok avatar Nov 30 '23 13:11 reosarevok