listenbrainz-android icon indicating copy to clipboard operation
listenbrainz-android copied to clipboard

Duplicate Listens reported

Open emmatebibyte opened this issue 1 year ago • 17 comments

When I listen to music on my phone, it’s reported as listened to twice or more times.

emmatebibyte avatar Jan 06 '24 06:01 emmatebibyte

@emmatebibyte Checkout release 2.5.0 and see if the pattern remains or is it fixed.

07jasjeet avatar Jan 06 '24 12:01 07jasjeet

I apologize, but I don’t see a release version 2.5.0.

On January 6, 2024 12:28:40 PM UTC, Jasjeet Singh @.***> wrote:

@emmatebibyte Checkout release 2.5.0 and see if the pattern remains.

-- Reply to this email directly or view it on GitHub: https://github.com/metabrainz/listenbrainz-android/issues/326#issuecomment-1879666582 You are receiving this because you were mentioned.

Message ID: @.***>

emmatebibyte avatar Jan 06 '24 17:01 emmatebibyte

@emmatebibyte Oh my apologies, 2.5.0 was released to beta. You can join the beta program (on play store) to test drive our newest features first!

07jasjeet avatar Jan 06 '24 17:01 07jasjeet

I do not use the Play Store, is there any other way to get this release?

On January 6, 2024 5:34:10 PM UTC, Jasjeet Singh @.***> wrote:

@emmatebibyte Oh my apologies, 2.5.0 was released to beta. You can join the beta program (on play store) to test drive our newest features first!

-- Reply to this email directly or view it on GitHub: https://github.com/metabrainz/listenbrainz-android/issues/326#issuecomment-1879763013 You are receiving this because you were mentioned.

Message ID: @.***>

emmatebibyte avatar Jan 06 '24 17:01 emmatebibyte

@emmatebibyte Usually, with normal releases, we attach the app's apk which is then pulled by other app stores like F-Droid. For beta releases unfortunately, we do not provide such facility. I suggest you to wait one or two days until we make an official release which will contain YIM 23 as well! On the other hand, you can also use play store to get your hands on the beta version.

07jasjeet avatar Jan 06 '24 17:01 07jasjeet

Its not fixed, on 2.6.1. currently . It spams like crazy. Every time you pause and play it submits again. Sometimes I don't even know why it repeats.

My entire stream is in doubles, triples, and even worst, sometimes 10s....

image

image

I am removing this app as it totally destroys my listening database.

majkinetor avatar Sep 22 '24 17:09 majkinetor

Hi, we'll be releasing a fix soon. We were testing a new implementation, checking how various devices submit listens. Keep an eye out.

07jasjeet avatar Sep 22 '24 17:09 07jasjeet

When is soon :) This is highly destructive and it lasts at least a year. I already removed it once because of this.

Interestingly, it didn't work this way initially.

majkinetor avatar Sep 22 '24 17:09 majkinetor

Coming week should be it

07jasjeet avatar Sep 22 '24 18:09 07jasjeet

@majkinetor @emmatebibyte, we have made a new beta release with version 2.7.2. Please test it out and let us know here :)

07jasjeet avatar Sep 27 '24 11:09 07jasjeet

I will, it will take a week or so.

Cheers.

majkinetor avatar Sep 27 '24 12:09 majkinetor

@07jasjeet, beta on play store is still 2.6.1.

Any other place with 2.7.2 ?

majkinetor avatar Sep 27 '24 12:09 majkinetor

@majkinetor it will be available in some time, maybe days. Play store reviews are taking time nowadays.

07jasjeet avatar Sep 27 '24 12:09 07jasjeet

Why not provide it here, in Releases (as pre release) ? It is available immediately in that way.

You already deliver apk in artifacts. It should be small CI intervention.

majkinetor avatar Sep 27 '24 17:09 majkinetor

@majkinetor here's the GitHub release. App's available on playstore as well.

07jasjeet avatar Sep 28 '24 05:09 07jasjeet

I did some testing last night.

Random duplicate listens are gone, which is awesome. True duplicate listens are gone too, though - if I put a song on repeat, I get only 1 listen. Given that the tool doesn't play music where it could have complete control over that, it looks understandable and I can live with that.

majkinetor avatar Sep 29 '24 09:09 majkinetor

@majkinetor can you please disable battery optimisations for app and test it again?

07jasjeet avatar Sep 29 '24 10:09 07jasjeet

It still happens, although it is significantly reduced. Also, it can't generally detect repeats.

For example, today:

image

I did repeat Crooked Colors which is shown 2 times here, although I repeated it 2 times. I did not repeat Synkro nor paused it yet it is listed 3 times. This is the first time I observed something like that, its usually the opposite - pausing the song may make it appear multiple times (but like I said, less frequent then prior to this beta release)

In general, I can live with omitted song repetitions, multiple records on the other hand spoil listening statistics quite a lot.

majkinetor avatar Oct 07 '24 17:10 majkinetor

@majkinetor This is a case with long songs. When you pause long songs in-between or there is a notification in between a long song, we do not know if you are repeating the same song again (android doesn't tell us), also sometimes android doesn't tell us the duration of your song as well (android limitation as well), so we don't know when your song is going to end as well and have to estimate it. We are fully aware of these cases and decided upon multiple listens than none at all.

Did the service work well to report all songs after disabled battery optimisation?

07jasjeet avatar Oct 08 '24 08:10 07jasjeet

We are fully aware of these cases and decided upon multiple listens than none at all.

This is bad decision. Multiple random listens spoils statistics in very random manner. Not having multiple real listens spoils it way less since you a) usually do not listen 1 song over and over b) it influences that one song statistics only.

Did the service work well to report all songs after disabled battery optimisation?

No. Like I said, it does less spam than before, but it still does it.

majkinetor avatar Oct 08 '24 10:10 majkinetor

BTW, I never had this with Simple Scrobbler.

majkinetor avatar Oct 08 '24 10:10 majkinetor