Sep 27 '20 09:09 slipset

Codecov Report

Merging #29 into master will decrease coverage by 0.05%. The diff coverage is 84.50%.

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
- Coverage   67.82%   67.77%   -0.06%     
==========================================
  Files           9        9              
  Lines         575      574       -1     
  Branches       70       70              
==========================================
- Hits          390      389       -1     
  Misses        115      115              
  Partials       70       70

Impacted Files	Coverage Δ
src/saml20_clj/sp/metadata.clj	`6.45% <0.00%> (ø)`
src/saml20_clj/sp/request.clj	`84.21% <ø> (ø)`
src/saml20_clj/sp/response.clj	`46.70% <50.00%> (ø)`
src/saml20_clj/crypto.clj	`76.74% <78.57%> (ø)`
src/saml20_clj/coerce.clj	`74.50% <88.46%> (ø)`
src/saml20_clj/xml.clj	`100.00% <100.00%> (ø)`
src/saml20_clj/core.clj	`100.00% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 86ae2eb...2834568. Read the comment docs.

Sep 29 '20 07:09 codecov[bot]

I'm of two minds about a change like this. I do like making the code a little less cluttery by importing all of the class names. It makes working on the library code a little nicer. On the other hand, I think having the full class names present everywhere makes the library easier to use for consumers of the library. If you're using the library and you jump to a function definition it saves you a step to know it takes a whatever.long.package.name.X509Certificate instead of seeing X509Certificiate and then having to jump to the top of the namespace to figure out what package it's from.

Sep 29 '20 20:09 camsaul

Explicitly add imports for java classes

Codecov Report