metabase icon indicating copy to clipboard operation
metabase copied to clipboard

Model action is being referred to as native question

Open kamilmielnik opened this issue 11 months ago • 2 comments

Describe the bug

While technically correct in a way, it's confusing from user's perspective.

https://github.com/user-attachments/assets/075f6a54-58ec-49a6-8072-ccfaed27fa58

To Reproduce

  1. Enable model actions in Sample DB
  2. New > Model > Notebook > Orders > Save
  3. Create basic actions in the model
  4. New > Dashboard
  5. Add text parameter
  6. Click text parameter to unselect it
  7. Add action button, connect it to "Create" action from model created in step 2, map "Email" field to "Text" parameter and hit "Done"
  8. Resize the action button card so you can see the warning message
  9. Click the text parameter

❌ The warning message mentions "native question variables" instead of "action parameters"

Expected behavior

Vocabulary in the message is relevant to the action card

Information about your Metabase installation

master, 2d6c18162b58954e57b8ac2ccfb2f45ebb45c2af

Severity

P3

kamilmielnik avatar Jan 30 '25 09:01 kamilmielnik

Reproducible on 1.51.13

Image

WiNloSt avatar Jan 31 '25 05:01 WiNloSt

Suggested message Action parameters only accept a single value. They do not support dropdown lists or search box filters, and can't limit values for linked filters.

KorowkaMu avatar Feb 13 '25 08:02 KorowkaMu

@KorowkaMu There are two messages:

  • Date parameter
Native question variables do not support dropdown lists or search box filters, and can't limit values for linked filters.
  • Any other
Native question variables only accept a single value. They do not support dropdown lists or search box filters, and can't limit values for linked filters.

Should I only fix the last one or both? If both, could you please suggest a message for the first option? Should it be the Action parameters do not support dropdown lists or search box filters, and can't limit values for linked filters. ?

spalt08 avatar Feb 20 '25 12:02 spalt08

@spalt08 yes, please fix both messages. Please, use the one you suggested for the date parameter.

KorowkaMu avatar Feb 20 '25 12:02 KorowkaMu