metabase icon indicating copy to clipboard operation
metabase copied to clipboard

Published 20 hours ago • verified publisher icon metabase

Convert ParametersList to TS

Open oisincoveney opened this issue 1 year ago • 1 comments

Converts ParametersList and SyncedParametersList to TS. It also unifies the props so there's less redundancy in type declarations

oisincoveney avatar May 17 '24 08:05 oisincoveney

Status Complete ↗︎
Commit d443e46fa672791134caf5baf055e71b8bfd3abb
Results
⚠️ 1 Flaky
✅ 2571 Passed

replay-io[bot] avatar May 17 '24 09:05 replay-io[bot]

Please also address https://github.com/metabase/metabase/pull/42777#discussion_r1613824062 in scope of this PR.

deniskaber avatar May 24 '24 20:05 deniskaber

I'll do it in #43221 so we can separate the PRs and isolate the logic for a better review

oisincoveney avatar May 28 '24 11:05 oisincoveney

@oisincoveney Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone?

github-actions[bot] avatar May 28 '24 12:05 github-actions[bot]