metabase icon indicating copy to clipboard operation
metabase copied to clipboard

remove unused viz series utils

Open EmmadUsmani opened this issue 1 year ago • 3 comments

Description

Removing some viz related code that is no longer used post-echarts migration.

How to verify

  1. New question -> Orders count by month
  2. Confirm chart renders

Demo

Screenshot 2024-05-10 at 8 19 17 AM

Checklist

  • [x] Tests have been added/updated to cover changes in this PR

EmmadUsmani avatar May 08 '24 20:05 EmmadUsmani

  • #42422 Graphite 👈
  • master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @EmmadUsmani and the rest of your teammates on Graphite Graphite

EmmadUsmani avatar May 08 '24 20:05 EmmadUsmani

Codenotify: Notifying subscribers in CODENOTIFY files for diff 1f416069d0c70c406b1fac195f116d2f82a5596d...3f82cba04242845fb12d1eed7428fa9b9842fdd7.

Notify File(s)
@alxnddr frontend/src/metabase/visualizations/lib/series.ts
frontend/src/metabase/visualizations/lib/series.unit.spec.ts

github-actions[bot] avatar May 08 '24 20:05 github-actions[bot]

Status Complete ↗︎
Commit 3f82cba04242845fb12d1eed7428fa9b9842fdd7
Results
⚠️ 6 Flaky
2475 Passed

replay-io[bot] avatar May 08 '24 20:05 replay-io[bot]

@EmmadUsmani Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone?

github-actions[bot] avatar May 10 '24 21:05 github-actions[bot]