metabase icon indicating copy to clipboard operation
metabase copied to clipboard

Don't throw an error when a partial permissions graph revision has no new changes

Open noahmoss opened this issue 2 years ago • 1 comments

Resolves #25221

noahmoss avatar Oct 25 '22 16:10 noahmoss

Codecov Report

Base: 64.14% // Head: 64.14% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (d74dff2) compared to base (590759f). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #26097   +/-   ##
=======================================
  Coverage   64.14%   64.14%           
=======================================
  Files        3103     3103           
  Lines       91531    91532    +1     
  Branches    11538    11539    +1     
=======================================
+ Hits        58711    58712    +1     
+ Misses      28200    28199    -1     
- Partials     4620     4621    +1     
Flag Coverage Δ
back-end 85.55% <100.00%> (+<0.01%) :arrow_up:
front-end 44.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/metabase/models/permissions.clj 83.95% <100.00%> (+0.03%) :arrow_up:
src/metabase/models/query.clj 92.30% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Oct 25 '22 18:10 codecov[bot]