metabase
metabase copied to clipboard
UI: the logo button should bring back to home, and the navbar should a standard icon for open/close
Fixes #23159
Before submitting the PR, please make sure you do the following
- [x] If you're attempting to fix a translation issue, please submit your changes to our POEditor project instead of opening a PR.
Tests
- [x] Run the frontend and Cypress end-to-end tests with
yarn lint && yarn test
) - [x] If there are changes to the backend codebase, run the backend tests with
clojure -X:dev:test
- [x] Sign the Contributor License Agreement (unless it's a tiny documentation change).
Demo
https://www.loom.com/share/309c4a3c6e5846fe84d59396a9798d11
TODO
- [x] Make logo button bring back to home.
- [x] Take out the action of opening/closing the navigation bar from the logo button.
- [x] Adjust behavior to design style.
Warning
These changes need to be verified against user experience. I tried to keep the design style. I haven't used the platform extensively, so it's possible that this solution affects other parts of the app, but it seems to me a little more adequate than the initial proposal of the original issue.
Hey @gitstart, I'm not sure if it gives the best UX for users since the icon is hardly noticeable when collapsed. Maybe @kdoh can share his thoughts on the proper way to solve it if we do want to tackle it.
![]()
Thank you @alxnddr for the review. @kdoh any suggestions on how to improve the UX would be of great help cc: @alxnddr
Codecov Report
Merging #24095 (7286b64) into master (95c8a0f) will decrease coverage by
0.01%
. The diff coverage is0.00%
.
@@ Coverage Diff @@
## master #24095 +/- ##
==========================================
- Coverage 65.22% 65.20% -0.02%
==========================================
Files 2768 2768
Lines 84842 84845 +3
Branches 10462 10464 +2
==========================================
- Hits 55335 55327 -8
- Misses 25191 25203 +12
+ Partials 4316 4315 -1
Flag | Coverage Δ | |
---|---|---|
back-end | 85.75% <ø> (-0.01%) |
:arrow_down: |
front-end | 46.41% <0.00%> (-0.02%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
...abase/nav/components/AppBar/AppBarLarge.styled.tsx | 55.55% <ø> (-13.68%) |
:arrow_down: |
...src/metabase/nav/components/AppBar/AppBarLarge.tsx | 66.66% <ø> (ø) |
|
...tabase/nav/components/AppBar/AppBarLogo.styled.tsx | 100.00% <ø> (ø) |
|
...se/nav/containers/MainNavbar/MainNavbar.styled.tsx | 0.00% <0.00%> (ø) |
|
...abase/nav/containers/MainNavbar/MainNavbarView.tsx | 0.00% <0.00%> (ø) |
|
src/metabase/task/sync_databases.clj | 77.08% <0.00%> (-3.48%) |
:arrow_down: |
src/metabase/driver/impl.clj | 70.21% <0.00%> (+1.06%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 95c8a0f...7286b64. Read the comment docs.
Closing this PR since there's no confirmation on the design yet
Hello there,
Is there any news on this PR? It is a substantial QoL improvement if implemented. Current sidebar implementation is not even persistent on its state (open/closed) when roaming the dashboards/questions and grabs too much space in addition to what was sought to be fixed with this PR.
And also in my opinion, it would be perfect to combine two 'Home' ideations: the current 'last visited' and the previous one with pinned items.
Many thanks