metabase
metabase copied to clipboard
[Epic] Clean up LDAP and Google auth set-up experience
Links
Product doc: https://www.notion.so/metabase/Clean-up-LDAP-and-Google-auth-set-up-experience-7499d138cf9845f9ab0b8fa459c1a7e1
Fixes
- https://github.com/metabase/metabase/issues/5555
- https://github.com/metabase/metabase/issues/16225
- https://github.com/metabase/metabase/issues/16363
Implementation plan
Milestone 1 - LDAP
- [ ] BE - https://github.com/metabase/metabase/pull/25421
- [ ] FE - https://github.com/metabase/metabase/pull/25439
Milestone 2 - Google Auth
- [ ] BE - Make it possible to configure and enable Google Auth separately (see the API changes below)
- [ ] FE - Add the Google Auth toggle to the card
API changes
Expose the following settings:
-
ldap-configured- readonly setting; set to true when ldap settings have been validated and saved -
ldap-enabled- can be changed only whenldap-configuredistrue -
google-auth-configured- readonly setting; set to true when google auth settings have been validated and saved -
google-auth-enabled- can be changed only whengoogle-auth-configuredistrue
Change POST /api/ldap/settings
- Remove
ldap-enabledcheck, settings should be always validated - Set
ldap-configuredto true when saved successfully - Set
ldap-enabledto true as well when previouslyldap-configuredwas false
Add POST /api/google_auth/settings
- Accept
google-auth-client-idandgoogle-auth-auto-create-accounts-domain - Perform the same validation when these settings are changed with
/api/setting - Set
google-auth-configuredto true when saved successfully - Set
google-auth-enabledto true as well when previouslygoogle-auth-configuredwas false