llama3
llama3 copied to clipboard
Update examples to give clear error messages
This PR updates the example scripts to confirms that the max_seq_len
is within an acceptable range (1 <= max_seq_len <= 8192
), and the given ckpt_dir
(checkpoint directory), tokenizer_path
(tokenizer file paths) exist and gives clear error messages.
Hi @aakashapoorv!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed
. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
Thanks @aakashapoorv I think it might be better to add the asserts in the build
function instead of in the example scripts. https://github.com/meta-llama/llama3/blob/cc44ca2e1c269f0e56e6926d7f4837c983c060dc/llama/generation.py#L37
@subramen Thanks for the suggestion! Thats better, I've moved the assertions into the build function of the Llama class 😊