llama icon indicating copy to clipboard operation
llama copied to clipboard

Save bandwidth by using a torrent to distribute more efficiently

Open ChristopherKing42 opened this issue 2 years ago • 284 comments
trafficstars

ChristopherKing42 avatar Mar 02 '23 23:03 ChristopherKing42

Hi @ChristopherKing42!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Mar 02 '23 23:03 facebook-github-bot

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot avatar Mar 03 '23 01:03 facebook-github-bot

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot avatar Mar 03 '23 01:03 facebook-github-bot

Good catch! This will save millions in bandwidth costs.

BetaDoggo avatar Mar 03 '23 02:03 BetaDoggo

my fucking sides

ewof avatar Mar 03 '23 02:03 ewof

i love the internet

mrcichon avatar Mar 03 '23 07:03 mrcichon

Big if true.

jp-x-g avatar Mar 03 '23 11:03 jp-x-g

At this point Meta should publish the original checksums so that we know if it's the real model. It appears that PyTorch models can execute arbitrary code, so this might as well be a clever attack..

zb3 avatar Mar 03 '23 12:03 zb3

Could've helped with.. uh.. reducing bandwidth, but don't have enough space for the entire model, anyone else distributing the load?

hatkidchan avatar Mar 03 '23 13:03 hatkidchan

At this point Meta should publish the original checksums so that we know if it's the real model. It appears that PyTorch models can execute arbitrary code, so this might as well be a clever attack..

Just convert them to safetensors on a VM or cloud computer.

Fannovel16 avatar Mar 03 '23 13:03 Fannovel16

I kneel

Disconsolance avatar Mar 03 '23 13:03 Disconsolance

the magnet link is broken. update your pull request pls

d9j avatar Mar 03 '23 14:03 d9j

I can't sneed

nukeop avatar Mar 03 '23 14:03 nukeop

@d9j I am being told by my source that it takes like 20 minutes to find peers. I have not yet tried it myself though since it isn't official until this pull request gets merged.

ChristopherKing42 avatar Mar 03 '23 16:03 ChristopherKing42

Dead lol

bizop avatar Mar 03 '23 16:03 bizop

this is the best thing i've seen in quite a while thank you for the laughs

RubberDuckShobe avatar Mar 03 '23 16:03 RubberDuckShobe

LGTM.

dasayan05 avatar Mar 03 '23 16:03 dasayan05

LGTM

ghost avatar Mar 03 '23 17:03 ghost

LGTM

vukosim avatar Mar 03 '23 17:03 vukosim

At this point Meta should publish the original checksums so that we know if it's the real model. It appears that PyTorch models can execute arbitrary code, so this might as well be a clever attack..

The community came through in #87 🫡

altryne avatar Mar 03 '23 17:03 altryne

looks like some people have been complaining about the link. it will need more seeders before we can merge into main

glample avatar Mar 03 '23 17:03 glample

lgtm

kh3dron avatar Mar 03 '23 17:03 kh3dron

LGTM

NotNite avatar Mar 03 '23 18:03 NotNite

LGTM

BennySaeedian avatar Mar 03 '23 18:03 BennySaeedian

lgtv

owovin avatar Mar 03 '23 18:03 owovin

Where are all you people coming from? XD

ChristopherKing42 avatar Mar 03 '23 19:03 ChristopherKing42

Where are all you people coming from XD.

Hacker News :)

zb3 avatar Mar 03 '23 19:03 zb3

LGTM

srustagi avatar Mar 03 '23 19:03 srustagi

LGTM

WillFP avatar Mar 03 '23 19:03 WillFP

Do people really do code reviews where they just say "LGTM"? What's the point of doing a review like that in the first place?

nukeop avatar Mar 03 '23 19:03 nukeop