feat: Pass parallel_tool_calls correctly

Open anastasds opened this issue 1 month ago • 3 comments

What does this PR do?

Closes #4123

A set of changes were introduced by the pre-commit hook. The relevant change here is in streaming.py.

Test Plan

Manual verification.

Nov 19 '25 19:11 anastasds

This pull request has merge conflicts that must be resolved before it can be merged. @anastasds please rebase it. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

Nov 19 '25 19:11 mergify[bot]

I think this PR is a bit too small -- as in, we could do more here?

Nov 19 '25 19:11 ashwinb

@ashwinb It's a one line change, yes, but it fixes broken behavior. As a relative newcomer to the codebase, it took some time to figure out where the problem was - for example, grepping the codebase for "call_ led me down the wrong path for a while.

What do you have in mind for "more"? I originally had added an integration test for this after the max_tool_calls integration test for the responses API, only to find after pulling main that it had been removed. I would be happy to add it back in, but I don't know whether it will be a reliable test given that it has to do with tool calling, which, as far as I know, is known to be unreliable for anything less than the largest models.

Nov 20 '25 13:11 anastasds