llama-stack icon indicating copy to clipboard operation
llama-stack copied to clipboard

Added implementations for get_agents_session, delete_agents_session and delete_agents

Open cheesecake100201 opened this issue 1 year ago • 1 comments

Added implementations for not implemented methods for agents

cheesecake100201 avatar Oct 18 '24 07:10 cheesecake100201

Thank you. I have some minor comments. It would be good to add a test or two? See the tests in providers/tests/agents/test_agents.py -- I would suggest making another file for just testing agent persistence (which is what this PR mostly targets.)

Will make another PR for that if thats okay with you. And what I need to test is deleting session and agent, and getting turns and steps. Please do add whatever else is needed to be tested

cheesecake100201 avatar Oct 18 '24 16:10 cheesecake100201

Made formatting changes shown in pre-commit @ashwinb

cheesecake100201 avatar Oct 22 '24 20:10 cheesecake100201

Merged, thanks!

ashwinb avatar Oct 22 '24 20:10 ashwinb