llama-stack icon indicating copy to clipboard operation
llama-stack copied to clipboard

Require all builds passing before merging

Open terrytangyuan opened this issue 1 year ago • 5 comments

🚀 Describe the new functionality needed

We should require all builds passing before merging.

💡 Why is this needed? What if we don't build it?

To avoid merging PRs like https://github.com/meta-llama/llama-stack/pull/1650 without passing builds, which broke pre-commit check on main branch.

Other thoughts

No response

terrytangyuan avatar Mar 15 '25 03:03 terrytangyuan

@terrytangyuan i've done some project administration in other orgs - this is something you can configure in the GitHub repo settings

the project could also consider using a tool like Mergify to automate PRs merging and Merge Queues such as described in https://github.com/meta-llama/llama-stack/issues/1629

nathan-weinberg avatar Mar 17 '25 12:03 nathan-weinberg

I see @leseb has proposed this very thing in https://github.com/meta-llama/llama-stack/pull/1667 😄

nathan-weinberg avatar Mar 17 '25 12:03 nathan-weinberg

Not surprised. @leseb lives on Github :-)

terrytangyuan avatar Mar 21 '25 00:03 terrytangyuan

This issue has been automatically marked as stale because it has not had activity within 60 days. It will be automatically closed if no further activity occurs within 30 days.

github-actions[bot] avatar May 27 '25 00:05 github-actions[bot]

Still not enforced.

leseb avatar May 27 '25 07:05 leseb

This issue has been automatically marked as stale because it has not had activity within 60 days. It will be automatically closed if no further activity occurs within 30 days.

github-actions[bot] avatar Jul 27 '25 00:07 github-actions[bot]

This issue has been automatically marked as stale because it has not had activity within 60 days. It will be automatically closed if no further activity occurs within 30 days.

github-actions[bot] avatar Oct 04 '25 00:10 github-actions[bot]

Tbh maybe this should be closed - it's a bit vague and we've removed the stale label thrice now

nathan-weinberg avatar Oct 04 '25 02:10 nathan-weinberg