Require all builds passing before merging
🚀 Describe the new functionality needed
We should require all builds passing before merging.
💡 Why is this needed? What if we don't build it?
To avoid merging PRs like https://github.com/meta-llama/llama-stack/pull/1650 without passing builds, which broke pre-commit check on main branch.
Other thoughts
No response
@terrytangyuan i've done some project administration in other orgs - this is something you can configure in the GitHub repo settings
the project could also consider using a tool like Mergify to automate PRs merging and Merge Queues such as described in https://github.com/meta-llama/llama-stack/issues/1629
I see @leseb has proposed this very thing in https://github.com/meta-llama/llama-stack/pull/1667 😄
Not surprised. @leseb lives on Github :-)
This issue has been automatically marked as stale because it has not had activity within 60 days. It will be automatically closed if no further activity occurs within 30 days.
Still not enforced.
This issue has been automatically marked as stale because it has not had activity within 60 days. It will be automatically closed if no further activity occurs within 30 days.
This issue has been automatically marked as stale because it has not had activity within 60 days. It will be automatically closed if no further activity occurs within 30 days.
Tbh maybe this should be closed - it's a bit vague and we've removed the stale label thrice now