WPF-Circular-Gauge icon indicating copy to clipboard operation
WPF-Circular-Gauge copied to clipboard

Wrong dependency property name

Open kaamil1984 opened this issue 4 years ago • 0 comments

Thanks for pretty gauge library!

I found little bug.

I tried to create a style, that contains MajorTickSize property and... I got an error, because there is no "MajorTickSize" dependency property, but I had no problem with "MinorTickSize".

Problem is here I guess:

https://github.com/mesta1/WPF-Circular-Gauge/blob/b60e10e0f89e6f9bf3171eb8e3feb08810e8184e/CircularGauge/CircularGauge/CircularGaugeControl.cs#L240

(MajorTickRectSize instead of MajorTickSize).

In the future I would suggest something like this:

nameof(MajorTickColor)

instead of

"MajorTickColor"

and this will be refactor-proof :)

Or maybe even change IntelliSense template.

kaamil1984 avatar May 09 '20 16:05 kaamil1984