Release version 0.6.0
There have been quite a few changes since the 0.5.0 release that would probably be worth a 0.6.0 release.
- #135
- #139
- #136
- #141
- #142
- #143 (breaking change)
- #145 (breaking change)
- #152 (breaking change)
- #156
- #133 and #161
- importantly #164 (breaking change)
- #166
- #168
- #169
- #171
- #172
- importantly #176
One thing that might be worth doing before pushing this would be to implement one of the solutions from https://github.com/messense/mupdf-rs/pull/149#issuecomment-2938681228 as otherwise mupdf-sys generates a lot of warnings on windows with rustc below version 1.89.0 (the latest stable version).
Probably 0.5.0 should be yanked after, due to #142, #176 and #159 (technically even all versions except for 0.0.1 because of 054f619ae1ade50de05ee777c5a2f26832af100d)
I've configured trusted publishing in crates.io for both mupdf-sys and mupdf, feel free to setup a github action to automate the publish process.
any update on this ?
One thing that might be worth doing before pushing this would be to implement one of the solutions from https://github.com/messense/mupdf-rs/pull/149#issuecomment-2938681228 as otherwise mupdf-sys generates a lot of warnings on windows with rustc below version 1.89.0 (the latest stable version).
This is still unresolved but I will probably come back to that in the next few days.
anyone have a good example of another project's github-actions for publishing ?
I'd really love to see 0.6.0 pushed to release and I'm willing to help push it over the line if needed/wanted.
What's the proposed mechanism for the github action?
- Create a release on github
- Action runs on release to compile and publish to crates.io
What is supposed to happen if the publish fails? For example if someone has forgotten to bump the version number in Cargo.toml.
I'm sure there are other possible failure states as well.
I already have an action that compiles my Rust project on creating a release, that should be easily repurposed into a cargo publish action if there are no well established ones already.
@vincent-uden here is the documentation which has a github actions example: https://crates.io/docs/trusted-publishing
I kinda outlined all of in the PR but now it is done.
We could almost just use the example from crates.io, the only thing that needed to be added was installing libfontconfig1-dev before compiling.
I think it should match your configuration @messense as long as you have setup the publish environment already
as long as you have setup the publish environment already
it was set up.
Are there any things somebody would like to do before the release, or is everything ready?
Not sure if this is a bug, but the latest release 0.6.0 doesn't show on docs.rs.
- 0.6.0 Release: https://github.com/messense/mupdf-rs/releases
- Doc.rs: https://docs.rs/mupdf/latest/mupdf/
Running cargo update still catches only 0.5.0.
Yea, the publish GitHub action had some bugs. Maybe the 4th try now is gonna work 🤪
Well, didn't work either. The mupdf-sys tar is too big to be published on crates.io. This needs to be fixed before this release can happen.
the remote server responded with an error (status 413 Payload Too Large): max upload size is: 15728640
This is the same problem as #72.
How big is the current packaged crate size? I think I did ask crates.io to increase the limit before to 15MiB (default is 10MiB) we can probably ask again.
I will check. I'm pretty certain there are quite some things that can be excluded as well, I will see how far I can get it down.