StakeDAO Ethereum QA

[this-username-is-taken]

https://docs.google.com/spreadsheets/d/1eCPV39j0O7q7t6poTFGzD-uuQ2p5hzEM/edit#gid=719745444

[bye43]

Will track here. Updates:

• @harsh9200 is adding a few missing vaults and then will re-QA
• We are tracking all passive strategies and liquidity lockers

[bye43]

@harsh9200 tracking a few questions/issues here:

• [x] Revenue for 0x5af15da84a4a6edf2d9fa6720de921e1026e37b7 seems off. Recording roughly $15,435 in supplySideRevenueUSD for 11/2022 when avg TVL was 9.3M. This equates to about (((15,435/30)365100)/9,300,000) 2% and Stake DAO UI is reporting roughly 10%

• [ ] Stake DAO Curve.fi Factory USD Metapool: Frax outputTokenPriceUSD is 0, but should this just be totalValueLockedUSD/outputTokenSupply?

• [x] Some vaults, such as 0xdd007cb6005017e548c761c2d12d9aa03961c30a, 0xf3c2bdfccb75cafda3d69d807c336bede956563f, 0x035652a14e27de1d7ca36bff0c4dfc3e2f0749b4, have rewards like CRV and ANGLE which should be counted as revenue

• [ ] Mispricing for vaults causing TVL for them to be 0. See list below:

0x1bd865ba36a510514d389b2ea763bad5d96b6ff9
0xd6415ff2639835300ab947fe67bad6f0b31400c1
0x1513b44a589ffc76d0727968eb55da4110b39422
0x8881c497f6f5f2cecd0742c37c6840bcf5234535
0x35e27b68c75e5b6431b823ceb664537b91e87ffe
0x11d87d278432bb2ca6ce175e4a8b4abdade80fd0
0x4ca321e4966a6bcbc26c13921cd76cac7d1f1b02
0x7ca0a95c96cd34013d619effcb02f200a031210d
0x8194d5d07dc7b6354ecf1efd96755f01454870aa
0x2cfe0e7b0eff280d74c2f406c05511b9b7c72549

[melotik]

@harsh9200 how much more work do you expect on this? And are there any blockers right now?

[bye43]

@dmelotik @harsh9200 is updating the pricing library then we are going to implement it in StakeDAO and it should be good to go

[harsh9200]

@dmelotik Only pricing issues are left in Stake DAO. I have recently resumed working on the fixes. I will deploy a fix soon.