subgraphs icon indicating copy to clipboard operation
subgraphs copied to clipboard

Tokemak QA (Ethereum) Schema Version 1.3.0 Subgraph Version 1.0.0 Methodology Version 1.0.0

Open bye43 opened this issue 3 years ago • 2 comments

Description Value
Subgraph Reviewed https://subgraphs.messari.io/subgraph?endpoint=https://api.thegraph.com/subgraphs/name/messari/tokemak-ethereum&tab=protocol
Date Reviewed July 14 2022
Schema Version 1.2.0
Subgraph Version 1.0.0
Methodology Version 1.0.0
Evidence Spreadsheet https://docs.google.com/spreadsheets/d/1Q3ZvobLGkFPFQ2zDV6ONt5uMrrGeYCLN67lKaBJJmzQ/edit?usp=sharing

Metrics To Review

Protocol Metrics

Section Metric Issue  
financialsDailySnapshots dailySupplySideRevenueUSD OK   Not sure on this one, there are positive values being output, which seems correct if we are counting the emission of TOKE to LPs as supply side revenue since it is to my knowledge that LPs do not get the actual yield from their assets, but are given TOKE that is equivalent to their yield  
financialsDailySnapshots cumulativeSupplySideRevenueUSD Same as daily  
financialsDailySnapshots dailyProtocolSideRevenueUSD Not sure on this one, but going to make a note. Currently, this is outputting 0. I couldn't find anything in the Tokemak README about how we are calculating revenue from Tokemak, but token terminal is outputting a value for this that is based on the buyback of TOKE. If we are not using this methodology then protocolSideRevenue should be 0, so this might be ok.
financialsDailySnapshots cumulativeProtocolSideRevenueUSD Same as daily
financialsDailySnapshots dailyTotalRevenueUSD This value is 0 when there dailySupplySide revenue has positive values
financialsDailySnapshots cumulativeTotalRevenueUSD This is also 0, when there should be positive increasing values  

Pool Overview

Pool Metric Issue
All Pools ALL No outputs for any of the pools here

Pool Metrics

Pool Section Metric Issue
TokemakWethPool vaultDailySnapshots rewardTokenEmissionsAmount [0] Should be rewards via TOKE
TokemakWethPool vaultDailySnapshots rewardTokenEmissionsUSD [0] Should be output here since reward token is TOKE
TokemakWethPool vaultHourlySnapshots rewardTokenEmissionsAmount [0] Same as daily
TokemakWethPool vaultHourlySnapshots rewardTokenEmissionsUSD [0] same as daily

bye43 avatar Jul 14 '22 19:07 bye43

First issue: image image

Second issue: telegram-cloud-photo-size-1-5071309143746390696-x

bye43 avatar Oct 04 '22 13:10 bye43

In tokemak, the rewards (only source of revenue) is calculated offline and I remember that there were some plans made by the tokemak team to move all the rewards logic on chain, but still now no progress is made. Due to this we will not be able to populate (protocolSideRevenue and per vault SupplySideRevenue & protocolSideRevenue). We will only be able to get the supplySideRevenue earned by the whole protocol.

Because of this above, we will hold off on supporting Tokemak till revenues are onchain.

bye43 avatar Apr 04 '23 20:04 bye43