subgraphs icon indicating copy to clipboard operation
subgraphs copied to clipboard

Solarbeam QA (Moonriver) Schema Version 1.3.0 Subgraph Version 1.0.0 Methodology Version 1.0.0

Open bye43 opened this issue 3 years ago • 3 comments

Description Value
Subgraph Reviewed https://subgraphs.messari.io/subgraph?endpoint=https://api.thegraph.com/subgraphs/name/messari/solarbeam-moonriver&tab=protocol
Date Reviewed July 11 2022
Schema Version 1.3.0
Subgraph Version 1.0.0
Methodology Version 1.0.0
Evidence Spreadsheet https://docs.google.com/spreadsheets/d/1NOS8FPgnyJa-a3rKe_KcVbx5SZY-TZRa7JhU1z8QwPg/edit?usp=sharing

Metrics To Review

Protocol Metrics

Section Metric Issue
financialsDailySnapshots dailyVolumeUSD Trend looks good, but there are certain days where the volume reported on the subgraph is over 100% difference than Solarbeam UI. This could be a Solarbeam UI problem, but difference is worth looking into
financialsDailySnapshots dailySupplySideRevenueUSD 2% fee applied supposed to be 0.2% fee
financialsDailySnapshots cumulativeSupplySideRevenueUSD Looks good, but daily is off
financialsDailySnapshots dailyProtocolSideRevenueUSD 0.5% fee applied supposed to be 0.05% fee
financialsDailySnapshots cumulativeProtocolSideRevenueUSD Looks good, but daily is off
financialsDailySnapshots dailyTotalRevenueUSD 2.5% fee applied supposed to be 0.25% fee
financialsDailySnapshots cumulativeTotalRevenueUSD Looks good, but daily is off

Pool Overview

Pool Metric Issue
ALL POOLS Reward Token Missing SOLAR as a reward token
Solarbeam MOVR/xcKSM Base Yield % 930.00% being outputted, Solarbeam UI is 11.58%
SolarBeam MOVR/USDC Base Yield % 100010.56% being outputted, Solarbeam UI is 154.95%
Solarbeam ETH/WMOVR Base Yield % 19424.32% being outputted, Solarbeam UI is 43.40%
Solarbeam FRAX/ROME ALL This pool is the number one pool in TVL on the Solarbeam UI, but is not present in the subgraph's Pool Overview

Pool Metrics Pool Metrics were not loading for Solarbeam, so was not able to check pool metrics.

bye43 avatar Jul 11 '22 13:07 bye43

@bye43 this is ready to be reviewed again

this-username-is-taken avatar Jul 18 '22 04:07 this-username-is-taken

Description Value
Subgraph Reviewed https://subgraphs.messari.io/subgraph?endpoint=https://api.thegraph.com/subgraphs/name/messari/solarbeam-moonriver&tab=protocol
Date Reviewed July 18 2022
Schema Version 1.3.0
Subgraph Version 1.0.0
Methodology Version 1.0.0
Evidence Spreadsheet https://docs.google.com/spreadsheets/d/1MZhEfgme7jKN5PUeCrmp8vaJZmU-nC8ppIV_-OZ_sQY/edit?usp=sharing

Pool Overview

Pool Metric Issue
Solarbeam MOVR/xcKSM Reward Tokens Outputting No Reward Token, should be SOLAR and other bribed tokens (ex. MOVR). Link that displays reward tokens - https://app.solarbeam.io/farm
Solarbeam MOVR/xcKSM Base Yield % Should be similar to Solarbeam UI, but numbers are way too large. Solarbeam UI outputting 3.19% and subgraph 95.41%. There might a difference here in methodology which could lead to different values, Solarbeam calculates base yield as (lastDayVolume * 0.002 * 365 * 100) / pairLiquidity and I am not exactly sure how we do, but regardless should be in the same ball park. Link - https://analytics.solarbeam.io/pairs
SolarBeam MOVR/USDC Reward Tokens Outputting No Reward Token, should be SOLAR and other bribed tokens (ex. MOVR). Link that displays reward tokens - https://app.solarbeam.io/farm
SolarBeam MOVR/USDC Base Yield % Should be similar to Solarbeam UI, but numbers are way too large. Solarbeam UI outputting 13.89% and subgraph 6176.44%. There might a difference here in methodology which could lead to different values, Solarbeam calculates base yield as (lastDayVolume * 0.002 * 365 * 100) / pairLiquidity and I am not exactly sure how we do, but regardless should be in the same ball park. Link - https://analytics.solarbeam.io/pairs
Solarbeam ETH/WMOVR Reward Tokens Outputting No Reward Token, should be SOLAR and other bribed tokens (ex. MOVR). Link that displays reward tokens - https://app.solarbeam.io/farm
Solarbeam ETH/WMOVR Base Yield % Should be similar to Solarbeam UI, but numbers are way too large. Solarbeam UI outputting 6.74% and subgraph 1145.38%. There might a difference here in methodology which could lead to different values, Solarbeam calculates base yield as (lastDayVolume * 0.002 * 365 * 100) / pairLiquidity and I am not exactly sure how we do, but regardless should be in the same ball park. Link - https://analytics.solarbeam.io/pairs

Pool Metrics Pool data still not loading, so have not been able to QA this.

bye43 avatar Jul 18 '22 14:07 bye43

This is ready for another round

this-username-is-taken avatar Aug 20 '22 15:08 this-username-is-taken

Description Value
Subgraph Reviewed https://subgraphs.messari.io/subgraph?endpoint=https://api.thegraph.com/subgraphs/name/messari/solarbeam-moonriver&tab=protocol
Date Reviewed August 31 2022
Schema Version 1.3.0
Subgraph Version 1.1.3
Methodology Version 1.0.0
Evidence Spreadsheet https://docs.google.com/spreadsheets/d/1loo3Rm4mCaXLEsudCKj6k1Ct_pB6pc_nPLwKpbEh2Jc/edit?usp=sharing

Metrics To Review

Pool Overview

Pool Metric Issue
Solarbeam MOVR/xcKSM Reward Tokens The Reward tokens look correct here, but the APR looks too low compared to the solarbeam UI - https://app.solarbeam.io/farm
SolarBeam MOVR/USDC Reward Tokens The Reward tokens look correct here, but the APR looks too low compared to the solarbeam UI - https://app.solarbeam.io/farm
Solarbeam ETH/WMOVR Reward Tokens The Reward tokens look correct here, but the APR looks too low compared to the solarbeam UI - https://app.solarbeam.io/farm
Some Pools Reward Tokens Looks like a lot of these pools are outputting the correct reward tokens, but the APY / Emissions do not look correct

Pool Metrics

Pool Section Metric Issue
Solarbeam Wrapped MOVR/USD Coin liquidityPoolDailySnapshots rewardTokenEmissionAmount [1] - SOLAR Subgraph is outputting 356.915 SOLAR / day and it looks like it is 5,000 SOLAR / day here on the solarbeam UI- https://app.solarbeam.io/farm
Solarbeam Wrapped MOVR/USD Coin liquidityPoolDailySnapshots rewardTokenEmissionAmount [4] - MOVR Subgraph is outputting 28 MVR/ day and it looks like it is closer to 400 MVR / day on Solarbeam UI - https://app.solarbeam.io/farm
Solarbeam Wrapped MOVR/USD Coin liquidityPoolDailySnapshots rewardAPR The reward APR for SOLAR and MOVR look like they are close to 53% on the solarbeam UI. https://app.solarbeam.io/farm
Solarbeam Wrapped liquid staked KSM/xcKSM liquidityPoolDailySnapshots All metrics besides TVL This pool is outputting 0 dailyVolumeUSD when it has volume. This is probably why alot of the metrics are 0'ed. There is volume though for the token amount. Link to Solarbeam UI - https://analytics.solarbeam.io/pairs/0x5568872bc43bae3757f697c0e1b241b62eddcc17. Link to query - https://api.thegraph.com/subgraphs/name/messari/solarbeam-moonriver/graphql?query=%7B%0A++liquidityPool+%28id%3A+%220x5568872bc43bae3757f697c0e1b241b62eddcc17%22%29+%7B%0A++++name%0A++++dailySnapshots+%28orderBy%3A+timestamp%2C+orderDirection%3A+desc%29+%7B%0A++++++dailyVolumeUSD%0A++++++dailyVolumeByTokenAmount%0A++++%7D%0A++%7D%0A%7D

bye43 avatar Sep 01 '22 02:09 bye43

This has been deployed and you can review again!

steegecs avatar Sep 03 '22 20:09 steegecs

Fixed and indexed. Will graft soon

this-username-is-taken avatar Sep 27 '22 17:09 this-username-is-taken

There is one more issue with Solarbeam:

Pool Metrics

Pool Section Metric Issue
Solarbeam Wrapped liquid staked KSM/xcKSM liquidityPoolDailySnapshots rewardTokenEmissionAmount The reward array is off (i.e. SOLAR is being represented as wstKSM)

bye43 avatar Sep 27 '22 18:09 bye43

Okay - Going to graft the change for fixing the liquidity pool TVLs, and then work on the reward emissions fix as a lower priority.

steegecs avatar Sep 27 '22 20:09 steegecs

Grafted and PR merged.

steegecs avatar Sep 29 '22 00:09 steegecs

@steegecs going to move reward emissions to its own issue here: https://github.com/messari/subgraphs/issues/1104

bye43 avatar Sep 29 '22 03:09 bye43

@bye43 should we get this ingested given the only issue is rewards?

this-username-is-taken avatar Sep 30 '22 01:09 this-username-is-taken

@this-username-is-taken Ya that sounds good! I will let JS know.

bye43 avatar Sep 30 '22 02:09 bye43