subgraphs
subgraphs copied to clipboard
messari
Curve QA (Ethereum) Schema Version 1.2.1 Subgraph Version 1.0.0 Methodology Version 1.0.0
| Description | Value |
|---|---|
| Subgraph Reviewed | https://subgraphs.messari.io/subgraph?endpoint=https://api.thegraph.com/subgraphs/name/messari/curve-finance-ethereum&tab=protocol |
| Date Reviewed | June 8th 2022 |
| Schema Version | 1.2.1 |
| Subgraph Version | 1.0.0 |
| Methodology Version | 1.0.0 |
| Evidence Spreadsheet | https://docs.google.com/spreadsheets/d/1Upp-puGDU5WVAQLzoNzrWKJSLA6AibZWQmBNrH0IgoI/edit?usp=sharing |
Metrics To Review
Protocol Metrics
| Section | Metric | Issue |
|---|---|---|
| financialsDailySnapshots | totalValueLockedUSD | Numbers seems way too big |
| financialsDailySnapshots | dailyVolumeUSD | Numbers are off for multiple days |
| financialsDailySnapshots | cumulativeVolumeUSD | Daily numbers off, so cumulative will also be |
| financialsDailySnapshots | dailySupplySideRevenueUSD | Negative values for revenue |
| financialsDailySnapshots | cumulativeSupplySideRevenueUSD | Daily is off, so cumulative will also be |
| financialsDailySnapshots | dailyProtocolSideRevenueUSD | Numbers are too big |
| financialsDailySnapshots | cumulativeProtocolSideRevenueUSD | Daily off, so cumulative too |
| financialsDailySnapshots | dailyTotalRevenueUSD | Supply and protocol side are off, so total will also be off |
| financialsDailySnapshots | cumulativeTotalRevenueUSD | Daily is off, so cumulative will also be |
| usageMetricsHourlySnapshots | hourlyActiveUsers | Outputting Daily Time Series |
| usageMetricsHourlySnapshots | hourlyTransactionCount | Same as above |
| usageMetricsHourlySnapshots | hourlyDepositCount | Same as above |
| usageMetricsHourlySnapshots | hourlyWithdrawCount | Same as above |
| usageMetricsHourlySnapshots | hourlySwapCount | Same as above |
Pool Overview Metrics
| Pool | Metric | Issue |
|---|---|---|
| Curve.fi DAI/USDC/USDT | Reward Tokens | Currently appearing as 73.30% CRV is 0.21% CRV on the Curve UI |
| Curve.fi DAI/USDC/USDT | Base Yield % | Negative Value |
Pool Metrics
| Pool | Section | Metric | Issue |
|---|---|---|---|
| Curve.fi DAI/USDC/USDT | liquidityPoolDailySnapshots | rewardTokenEmissions - USD | This does not look right since token emissions are in USD. Should be rewardTokenEmissionsAmount (CRV) * Average CRV price for that day and is not. |
| Curve.fi DAI/USDC/USDT | liquidityPoolDailySnapshots | baseYield | Negative Value |
| Curve.fi DAI/USDC/USDT | liquidityPoolDailySnapshots | rewardAPR | APR is too high |
| Curve.fi DAI/USDC/USDT | liquidityPoolHourlySnapshots | ALL HOURLY | Hourly Snapshots are outputting Daily Time Series |
| Description | Value |
|---|---|
| Subgraph Reviewed | https://subgraphs.messari.io/subgraph?endpoint=https://api.thegraph.com/subgraphs/name/messari/curve-finance-ethereum&tab=protocol |
| Date Reviewed | August 23 2022 |
| Schema Version | 1.3.0 |
| Subgraph Version | 1.0.0 |
| Methodology Version | 1.0.0 |
| Evidence Spreadsheet | https://docs.google.com/spreadsheets/d/1skBAP8_WZHys5SBhgbISggJK3RUwVRaO9KphnXMLMUI/edit?usp=sharing |
Metrics To Review
Protocol Metrics
| Section | Metric | Issue |
|---|---|---|
| financialsDailySnapshots | totalValueLockedUSD | This looks much better than list time, but some of the earlier months (01/01/2022, 02/01/2022, 03/01/2022) have values that are >15% difference. Also on 10/10/2021 and 10/09/2021 there is a spike to 36b that looks incorrect (150% difference than defiLlama) |
| financialsDailySnapshots | dailyVolumeUSD | General trend looks pretty good here compared to last time, but there are multiple dates that are 80%-90% difference compared to token terminal (05/01/2022, 04/01/2022, 03/01/2022) |
| financialsDailySnapshots | cumulativeVolumeUSD | This is off because daily is, but the cumulative is adding correctly and overall the cumulative values do not seem that far off from token terminal |
| financialsDailySnapshots | dailySupplySideRevenueUSD | These values are way too high (>1M% difference). Multiple days reporting millions in supply side revenue. This might be due to rewards (CRV emissions) being counted as revenue when they should not be. |
| financialsDailySnapshots | cumulativeSupplySideRevenueUSD | Daily is off, so cumulative will also be |
| financialsDailySnapshots | dailyProtocolSideRevenueUSD | Multiple dates with >100% difference than token terminal. |
| financialsDailySnapshots | cumulativeProtocolSideRevenueUSD | Daily off, so cumulative too |
| financialsDailySnapshots | dailyTotalRevenueUSD | Supply and protocol side are off, so total will also be off. Probably because of supply side revenue being so high, but subgraph values are also >1m% difference |
| financialsDailySnapshots | cumulativeTotalRevenueUSD | Daily is off, so cumulative will also be |
Pool Overview
| Pool | Metric | Issue |
|---|---|---|
| Curve.fi ETH/stETH | Input Token | Looks like ETH is not being reported as an input token for this pool. The address I am seeing is 0xeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee |
| All Pools | Reward Tokens | Looks like there are non CRV rewards being displayed, but there are no CRV rewards for any of the pools, which is incorrect |
| Some Pools | Bonus Rewards | Pools, such as Curve.fi ETH/stETH, Curve.fi Factory USD Metapool: Liquity, Curve.fi MUSD/3Crv, have non CRV rewards, such as LDO, LQTY, MTA, but it looks like emissions for these tokens are being recorded as 0. Looks like these should be >0 based on Curve UI - https://curve.fi/pools |
Pool Metrics
| Pool | Section | Metric | Issue |
|---|---|---|---|
| Curve.fi DAI/USDC/USDT | liquidityPoolDailySnapshots | dailySupplySideRevenueUSD | This should be about 50% of 0.01% of daily volume, but subgraph values are outputting way higher (313816.44%% difference). Could be rewards being counted as revenue again? Link to Curve UI that shows fee split - https://curve.fi/3pool |
| Curve.fi DAI/USDC/USDT | liquidityPoolDailySnapshots | cumulativeSupplySideRevenueUSD | Daily is off, so this will be too. Adding correctly though |
| Curve.fi DAI/USDC/USDT | liquidityPoolDailySnapshots | dailyProtocolSideRevenueUSD | Same as supply side notes. Does not look like supply and protocol side revenue are being split correctly either. I would expect them to be equal for this pool. |
| Curve.fi DAI/USDC/USDT | liquidityPoolDailySnapshots | cumulativeProtocolSideRevenueUSD | Daily is off, so this will be too. Adding correctly though |
| Curve.fi DAI/USDC/USDT | liquidityPoolDailySnapshots | dailyTotalRevenueUSD | Similar comments to supply side revenue. Values are way too large |
| Curve.fi DAI/USDC/USDT | liquidityPoolDailySnapshots | cumulativeTotalRevenueUSD | Daily is off, so this will be too. Adding correctly though |
| Curve.fi DAI/USDC/USDT | liquidityPoolDailySnapshots | outputTokenPriceUSD - 3Crv | This is outputting 0. Looks like on Curve UI it should be 1.0219. Link - https://curve.fi/3pool |
| Curve.fi DAI/USDC/USDT | liquidityPoolDailySnapshots | stakedOutputTokenAmount - 3Crv | Curve LPs can be staked for CRV. I believe there should be output here. Currently, subgraph is outputting nothing |
| Curve.fi DAI/USDC/USDT | liquidityPoolDailySnapshots | rewardTokenEmissions - Crv | No output here on subgraph. There should be CRV rewards here. |
| Curve.fi DAI/USDC/USDT | liquidityPoolDailySnapshots | rewardTokenEmissions - USD | No output here on subgraph. There should be CRV rewards here. |
| Curve.fi DAI/USDC/USDT | liquidityPoolDailySnapshots | rewardAPR | No output here on subgraph. There should be CRV rewards here. |
Comments were pretty similar compared to the last version QA, so adding a few things to previous comments. These issues are being addressed though.
| Description | Value |
|---|---|
| Subgraph Reviewed | https://subgraphs.messari.io/subgraph?endpoint=https://api.thegraph.com/subgraphs/id/QmReWoBpRvrMAH672QreRGnpUptWXjNGMMob4WggZjFad6&tab=protocol&version=pending |
| Date Reviewed | August 31 2022 |
| Schema Version | 1.3.0 |
| Subgraph Version | 1.0.0 |
| Methodology Version | 1.0.0 |
| Evidence Spreadsheet | https://docs.google.com/spreadsheets/d/1TTdieoiHVrMI8U86I0tdR2lu9ekVN85i7MB9T9QRnFE/edit?usp=sharing |
Metrics To Review
Protocol Metrics
| Section | Metric | Issue |
|---|---|---|
| financialsDailySnapshots | totalValueLockedUSD | Not ok there is a spike between 05/2021 - 07/2021 that looks like its from the Curve.fi cyDAI/cyUSDC/cyUSDT - 0x2dded6da1bf5dbdf597c45fcfaa3194e53ecfeaf. This is being addressed now |
| financialsDailySnapshots | dailyVolumeUSD | This looks ok right now. Going to leave as unsure since it seems like the cumulative is not matching up |
| financialsDailySnapshots | cumulativeVolumeUSD | This could be off because of the cyDAI/cyUSDT/cyUSDC pool. But the values at 06/30/2021 are roughly 38% off. This is from the token pricing and being addressed. |
| financialsDailySnapshots | dailySupplySideRevenueUSD | This is 20%-30% off from token terminal. This is because token terminal does not account for 0% admin fee on certain pool |
| financialsDailySnapshots | cumulativeSupplySideRevenueUSD | Same comments as supply side |
| financialsDailySnapshots | dailyProtocolSideRevenueUSD | Same comments as supply side |
| financialsDailySnapshots | cumulativeProtocolSideRevenueUSD | Same comments as supply side |
| financialsDailySnapshots | dailyTotalRevenueUSD | This generally looks good except for 06/06/2021. This is a pricing issue and being addressed |
Pool Overview
| Pool | Metric | Issue |
|---|---|---|
| Curve.fi ETH/stETH | Input Token | This address, "0xeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee", is still showing up for ETH, but seems like its working and being labeled appropriately |
Pool Metrics
| Pool | Section | Metric | Issue |
|---|---|---|---|
| Curve.fi USD-BTC-ETH | liquidityPoolDailySnapshots | dailyVolumeByTokenAmount[1] | This is outputting 0. Being addressed. |
| Curve.fi USD-BTC-ETH | liquidityPoolDailySnapshots | dailyVolumeByTokenAmount[2] | This is outputting in the E16. Being addressed. |
| Curve.fi USD-BTC-ETH | liquidityPoolDailySnapshots | inputTokenBalances [1] - WETH: Wrapped Ether | This is outputting 0. Being addressed. |
| Curve.fi USD-BTC-ETH | liquidityPoolDailySnapshots | inputTokenBalances [2] - USDT: Tether USD | This is outputting in the E16. Being addressed. |
| Curve.fi USD-BTC-ETH | liquidityPoolDailySnapshots | outputTokenSupply - crv3crypto: Curve.fi USD-BTC-ETH | There are 0'd values here. Being addressed |
| Curve.fi USD-BTC-ETH | liquidityPoolDailySnapshots | outputTokenPriceUSD - crv3crypto: Curve.fi USD-BTC-ETH | Spiking into exponential - fix in the work |
@this-username-is-taken @harsh9200 Closing this as its been ingested for Mainnet, moving existing issue here: https://github.com/messari/subgraphs/issues/1025