subgraphs icon indicating copy to clipboard operation
subgraphs copied to clipboard

Baseswap - BASE QA

Open SerenityFund opened this issue 2 years ago • 2 comments

Review Info

Description Info
Subgraph Reviewed https://subgraphs.messari.io/subgraph?endpoint=messari/baseswap-base&tab=protocol
Schema Version 1.3.2
Subgraph Version 1.0.0
Methodology Version 1.0.0
Evidence Spreadsheet https://docs.google.com/spreadsheets/d/1cR_ZC2agQtQvYe-_Gry5ldJVcYBpFspg/edit?usp=sharing&ouid=104027705798814439445&rtpof=true&sd=true

Metric to Review

Daily Total or Protocol Side Revenue

  • We've computed the daily total revenue/the protocol side revenue, and our findings indicate a value of 430.18, which is notably lower than the recent subgraph data of 98,288.86. Swap or trading fees are directed towards stakers of the protocol's native token $BSWAP at the discretion of the team. Essentially, all trading fees are directed to token holders or the protocol side. To review the detailed revenue computation, please refer to the 'Support-Implied-Revenue' sheet.
Subgraph - Daily Total or Protocol Side Revenue Daily Total or Protocol Side Revenue Absolute difference Difference %
$98,288.86 $430.18 $97,858.67 22,748.23%

Pool Overview - TVL

  • The TVL data for eight out of the top 10 pools closely corresponds to the data on the official website. However, notable discrepancies of -36.99% and -50.01% appear in the TVL figures for the wETH-BSWAP and DAI+-USD+ pools when compared to the official website.
Subgraph - WETH,BSWAP TVL Official Website - WETH,BSWAP TVL Difference %
$3,663,186.84 $2,674,069 36.99%
Subgraph - DAI+,USD+ TVL Official Website - DAI+,USD+ TVL Difference %
$1,241,869.38 $2,484,331 -50.01%
  • Refer to the sheet "Pool_Overview"

Pool Overview - Rewards

  • The data aligns with the understanding that there is no base yield data, as all trading fees are directed to the protocol. However, there should be reward token APR data ($BSWAP) available for all the pools.

Please refer to the attached worksheet for more details.

SerenityFund avatar Aug 21 '23 01:08 SerenityFund

@steegecs QA for baseswap looks like there is a couple of pools that may have pricing problems and that the fee percentage is not set right for revenue.

bye43 avatar Aug 21 '23 13:08 bye43

@steegecs I merged the current PR (before seeing this), the fixes can be in a new PR tho

melotik avatar Aug 22 '23 02:08 melotik