subgraphs icon indicating copy to clipboard operation
subgraphs copied to clipboard

New pricing library deployments with wrong TVL

Open bye43 opened this issue 2 years ago • 5 comments

@steegecs took a quick look at all the uni v2 forks on @dmelotik hosted service and here is the list of the ones that looks wrong

### Deployments
- [ ] Apeswap (BSC): https://okgraph.xyz/?q=dmelotik%2Fapeswap-bsc
- [ ] Quickswap (Matic): https://okgraph.xyz/?q=dmelotik%2Fquickswap-polygon
- [ ] Solarbeam (Moonriver):  https://okgraph.xyz/?q=dmelotik%2Fsolarbeam-moonriver
- [x] Spiritswap (Fantom): https://okgraph.xyz/?q=dmelotik%2Fspiritswap-fantom
- [ ] https://github.com/messari/subgraphs/issues/2168
- [ ] Trader Joe (Avalanche):  https://okgraph.xyz/?q=dmelotik%2Ftrader-joe-avalanche
- [ ] Honeyswap (Gnosis):  https://okgraph.xyz/?q=dmelotik%2Fhoneyswap-gnosis
- [ ] Pangolin (Avalanche):  https://okgraph.xyz/?q=dmelotik%2Fpangolin-avalanche
- [ ] https://github.com/messari/subgraphs/issues/1074
- [ ] https://github.com/messari/subgraphs/issues/1395
- [ ] Spookyswap (FTM): https://okgraph.xyz/?q=dmelotik/spookyswap-fantom
- [ ] Biswap (BSC): https://okgraph.xyz/?q=dmelotik/biswap-bsc
- [ ] mm-Finance (MATIC): https://okgraph.xyz/?q=dmelotik%2Fmm-finance-polygon

bye43 avatar May 19 '23 17:05 bye43

@dmelotik Trader Joe and Pangolin have indexing errors here. Everything on this list looks off still (besides spiritswap), but I still need to go through all of sushiswap v2/v3

bye43 avatar Jun 05 '23 16:06 bye43

I think some of the Sushiswap deployments that you flagged are not an issue. Let me know what you think.

Sushiswap Fuse

  • I think Defillama is wrong. I looked at the pools and there is a Tether/USDC pool that has 1.8 million TVL at one point, and the prices of each token are 1 USD as expected at that time. Screenshot 2023-06-12 at 9 01 51 AM

Sushiswap Gnosis

  • Looks fine to me? The chart matches Defillama and sushi analytics.

Sushiswap Harmony

  • I believe Defillama is wrong. Our chart matches Sushi analytics.

Sushiswap Polygon

  • It looks fine to me when I check Sushi Analytics and Defillama.

Sushiswap Celo

  • Our chart matches very closely Sushi analytics. I believe ours is correct. Defillama just flattens off.

steegecs avatar Jun 21 '23 00:06 steegecs

@steegecs Sorry, I realized that the links on that sushi issue were referring to the current messari-hosted service and not the sushiswap deployments on dylan's hosted. It looks like the majority of these are good on both the current messari and dylans hosted.

Sushiswap Fuse

  • This also looks good on both. My apologies!

Sushiswap Gnosis

  • This also looks good on both. My apologies!

Sushiswap Harmony

  • Dylan's hosted (https://okgraph.xyz/?q=dmelotik%2Fsushiswap-harmony) has a large TVL spike. Image

Sushiswap Polygon

  • For this believe the problem is and referenced here: https://github.com/messari/subgraphs/issues/1726. IIRC we discussed this last week and said it was due to defiLlama and us both dealing with Klima and Toucan Image

Sushiswap Celo

  • This also looks good on both. My apologies!

bye43 avatar Jun 21 '23 01:06 bye43

Redeployed all fixes to dmelotik/[subgraph-name] on my hosted service to make sure they worked:

  • apeswap-bsc
  • quickswap-polygon
  • trader-joe-avalanche
  • honeyswap-gnosis
  • pangolin-avalanche
  • sushiswap-arbitrum
  • sushiswap-avalanche
  • sushiswap-polygon
  • sushiswap-ethereum
  • sushiswap-harmony
  • mm-finance-polygon
  • biswap-bsc : waiting for lutter to prune

melotik avatar Jun 22 '23 01:06 melotik

@steegecs Took a look at the deployments that are 100% synced to head here looks like sushiswap -avalanche is gtg now. Here are the others that look like they are still struggling still (note - anything note on this list, I have not checked):

  • sushiswap-ethereum Image

  • sushiswap-harmony (looks close but the current TVL is being recorded on the subgraph in the millions and its 500k on sushiswap UI) Image Image

  • honeyswap-gnosis Image

  • mm-finance polygon (trend is similar here, but the mm-finance analytics page follows defiLlama, but defiLlama could be pulling from the API) Image Image

bye43 avatar Jun 27 '23 17:06 bye43