subgraphs icon indicating copy to clipboard operation
subgraphs copied to clipboard

SpookySwap - FANTOM QA

Open SerenityFund opened this issue 2 years ago • 4 comments

Review Info

Description Info
Subgraph Reviewed https://subgraphs.messari.io/subgraph?endpoint=messari/spookyswap-fantom&tab=protocol
Schema Version 1.3.0
Subgraph Version 1.1.5
Methodology Version 1.0.0
Evidence Spreadsheet https://docs.google.com/spreadsheets/d/112HyFT668emldzJRLiSp-xMzDJJFQp8Q/edit?usp=share_link&ouid=104027705798814439445&rtpof=true&sd=true

Metrics to Review

TVL Data

TVL data is not mathematically in line with both data from the official website and Defi Llama as it shows a 5-day average discrepancy of -16.34% and -14.57% respectively.

Subgraph's TVL 5-day average data Official Website's TVL 5-day average data Absolute Difference % Difference
86,436,583 103,308,760 -16,872,177 -16.34%
Subgraph's TVL 5-day average data Defi Llama's TVL 5-day average data Absolute Difference % Difference
86,436,583 101,280,761 -14,844,178 -14.57%
  • Refer to the sheet 'Protocol'

Daily Volume Data

Subgraph's 5-day average daily volume data shows a discrepancy of -8.87% and -7.19% with the official website and Token Terminal data respectively.

Although the figures are under the acceptable percentage of 10%, it still suggests that the subgraph data is slightly inaccurate considering the discrepancy in TVL data.

Subgraph's daily volume 5-day average data Official Website's daily volume 5-day average data Absolute Difference % Difference
14,803,086.91 16,282,044.80 -1,478,957.89 -8.87%
Subgraph's daily volume 5-day average data Token Terminal's daily volume 5-day average data Absolute Difference % Difference
14,803,086.91 15,983,012.02 -1,179,925 -7.19%
  • Refer to the sheet 'Protocol'

Revenue

The recent daily total revenue, supply side revenue, and protocol side revenue data have a discrepancy of -9.57% each with the implied revenue data.

Although it is below the acceptable discrepancy of 10%, it still suggests that it's slightly inaccurate which is the same as the daily volume data.

Moreover, the Token Terminal data supports this analysis as it shows a 5-day average discrepancy of -7.19% with the subgraph data.

Subgraph's daily total revenue data on Jan. 24, 2023 Official Website's daily total revenue data on Jan. 24, 2023 Absolute Difference % Difference
30,877.51 34,145.24 -3,268 -9.57%
Subgraph's daily total revenue 5-day average data Token Terminal's daily total revenue 5-day average data Absolute Difference % Difference
29,606 31,966 -2,360 -7.19%
  • Refer to the sheet 'Protocol'

Editorials

There are some errors we have noticed and are not necessarily data errors.

Pool Overview

  • The pool overview section cannot be accessed on our part as it says 'Failed to fetch'
  • Refer to the sheet 'Pool_Overview'

Pool

  • The subgraph query is not working no matter how long we wait and how many times the page is being refreshed.
  • Refer to the sheet 'Pool_vault_schema' and 'Pool_snapshots'

Events

  • The subgraph is not showing any data and only shows black screen.
  • Refer to the sheet 'Events'

Please refer to the attached worksheet for details.

SerenityFund avatar Jan 27 '23 01:01 SerenityFund

rewardTokens of LiquidityPool is empty [], can we have that fixed as well? Thx

TKYAngus avatar Feb 14 '23 04:02 TKYAngus

@bye43 what's the status on this? It seems to be fully indexed

this-username-is-taken avatar Apr 09 '23 02:04 this-username-is-taken

@this-username-is-taken I believe that the initial QA has still not been addressed and most of the issues are related to pricing. cc: @jaimehgb

bye43 avatar Apr 09 '23 14:04 bye43

Update: Pricing should be fixed with new pricing updates then the subgraph just needs to be redeployed

bye43 avatar Apr 10 '23 17:04 bye43