Harvest Finance Mainnet QA

[SerenityFund]

Review Info

Description	Info
Subgraph Reviewed	https://subgraphs.messari.io/subgraph?endpoint=https://api.thegraph.com/subgraphs/id/QmcBPHEPEB9VtgXFw9hefqh7jafZMr7LfLvn5knorGz8SH
Schema Version	1.3.0
Subgraph Version	0.1.0
Methodology Version	1.0.0
Evidence Spreadsheet	https://docs.google.com/spreadsheets/d/13Yc46gVMeKG_hsnUNgq2BdWyfIq0PwVu/edit?usp=share_link&ouid=104027705798814439445&rtpof=true&sd=true

Metric to Review

TVL

• The subgraph's TVL data shows a 20.19% five-day average discrepancy with data from Defi Llama which is significant. In addition, the discrepancy between the recent subgraph's and the official website's data also shows a high discrepancy of 14.53%.
• This is probably due to the reason that some vaults are missing in the subgraph data. For instance, the vault named 'Uniswap v3: ORC-ETH' has a TVL of $1.1 million and it is missing in the subgraph data.
• See 'Protocol' and 'Support-TVL-and-Revenue' sheets for more information.

Subgraph TVL 5-day average	Defi Llama 5-day average	Absolute Difference	% Difference
11,266,843	14,116,663	-2,849,820	-20.19%

Recent Subgraph TVL	Implied TVL	Absolute Difference	% Difference
11,266,843	13,139,050	-1,908,765.37	-14.53%

Revenue

• Daily revenue data must not be zero. Our computations for the implied revenue show that the total revenue for the recent data must be around $2,006.46 (including both Base APY an $FARM reward token APY).
• Refer to 'Protocol' and 'Support-TVL-and-Revenue' sheets

Subgraph Daily Supply Side Revenue	Implied Revenue	Absolute Difference	% Difference
0	1,410.10	-1,410.10	-100%

Subgraph Daily Protocol Side Revenue	Implied Revenue	Absolute Difference	% Difference
0	604.33	-604.33	-100%

Subgraph Total Daily Revenue	Implied Revenue	Absolute Difference	% Difference
0	2,006.46	-2,006.46	-100%

Daily Transaction Count

• The recent daily transaction count data (as well as the data from the 22nd and 23rd of December) is not in line with the sum of the daily deposit and withdraw transactions.
• Refer to the 'Protocol' sheet

Pool Overview

• Only 9 out of 50 vaults in the subgraph data are shown on the official website.
• Out of these 9 vaults, three vaults' TVL data have more than a 10% discrepancy with the official website TVL data. The vaults' names are iFARM, FARM_LOOKS, and FARM_cvxCRV.
• The top 7, 9-17, and 20-50 pools are inactive vaults and are not shown on the official website
• 11 vaults/pools on the official website are not shown in the subgraph data. See the 'Support-TVL-and-Revenue' sheet for more info. The missing vaults' names are Uniswap v3: ORC-ETH, Uniswap V3: CNG-ETH, Uniswap V3: ETH-sETH2, FARM/ETH, YEL-ETH, MUSE-ETH, Uniswap V3: WBTC-ETH, nDAI, CRV:TriCrypto2, FARMStead USDC-24, and FARM/GRAIN vaults.
• There must be $FARM Reward Token data for each active pool
• Refer to the 'Pool_Overview' sheet

Please refer to the attached worksheet for more details.

[bye43]

@llopez QA comments on harvest here!

[llopez]

thanks for reviewing the data. We will take a look and back to you.

[llopez]

We found the problem with dailyTransactionCount. We are tracking more than the withdrawals and deposits. We are also tracking the mint and burn. We will make the required changes to fix this issue

[llopez]

Regarding TVL our numbers are closer to the protocol's website than defi llama.

[bye43]

@llopez Is there another deployment with fixes that needs another QA?

[melotik]

@llopez do you have any notes on the difficulties you faced trying to address this issue?