NFT Subgraph QA

[bye43]

Description	Value
Subgraph Reviewed	LooksRare - https://api.thegraph.com/subgraphs/name/messari/looksrare-ethereum, Opensea V1 - https://api.thegraph.com/subgraphs/name/messari/opensea-v1-ethereum, Opensea V2 - https://api.thegraph.com/subgraphs/name/messari/opensea-v2-ethereum, Seaport. - https://api.thegraph.com/subgraphs/name/messari/opensea-seaport-ethereum, X2Y2 - https://api.thegraph.com/subgraphs/name/messari/x2y2-ethereum
Date Reviewed	October 19 2022
Schema Version	1.0.0
Subgraph Version	1.0.0
Methodology Version	1.0.0
Evidence Spreadsheet	https://docs.google.com/spreadsheets/d/19GS-m4sfklBL8Hzdf_GmmObAw-yF-_F6dQp_wwGX9_E/edit?usp=sharing

Metrics To Review

• [ ] Add USD Pricing for all ETH metrics - prob need to change the schema

Marketplace

Market	Section	Value	Status	Comments
Looksrare	marketplaceDailySnapshots	dailyActiveTraders	NOT OK	This is not matching the dune query (https://dune.com/queries/348068/662677) or the Looksrare official subgraph (https://api.thegraph.com/subgraphs/name/looksrare/exchange/graphql?query=%7B%0A++exchangeDailyDatas+%28orderBy%3A+date%2C+orderDirection%3A+desc%29+%7B%0A++++dailyUsers%0A++%7D%0A%7D)
X2Y2	marketplaceDailySnapshots	dailyActiveTraders	NOT OK	This looks off compared to nansen and dune, but dune and nansen are also pretty different from each other. See Marketplace_Snapshot in evidence sheet.
X2Y2	marketplaceDailySnapshots	dailyTradedItemCount	UNSURE	The values are like 5% off from the dune query (https://dune.com/queries/346386/1327479). I feel like this is somewhat of a big difference for the amount of items traded. Might need a second look.
OpenSea (v1, v2, Seaport)	marketplaceDailySnapshots	cumulativeUniqueTraders	NOT OK	This is probably correct for the three contracts, but we need to figure out a way to get a cumulative total since right now there is double counting of users between all three contracts
OpenSea (v1, v2, Seaport)	marketplaceDailySnapshots	dailyActiveTraders	UNSURE	The numbers do not match this dune query at all, but I am not sure if the query is correct (https://dune.com/queries/383396/731172?Graph+Timeframe_n26d66=365)
OpenSea (v1, v2, Seaport)	marketplaceDailySnapshots	dailyTradedItemCount	UNSURE	I think our number are probably right here. Could be that this dune query is only looking at a single contract when there are other trades also it could be excluding bundles (https://dune.com/queries/1453796)

Collections

Collection	Section	Value	Status	Comments
Looksrare - Terraforms (0x4E1f41613c9084FdB9E34E11fAE9412427480e56)	collectionDailySnapshot	dailyTradeVolumeETH	UNSURE	This is pretty interesting. Looks like both the looks subgraph and our subgraph are missing this weird wash trade looking transaction. Not sure if its a problem, but maybe quick double check would not hurt. See Collection_Snapshot tab
Looksrare - Terraforms (0x4E1f41613c9084FdB9E34E11fAE9412427480e56)	collectionDailySnapshot	dailyTradedItemCount	NOT OK	I think this might be a difference of when we are taking our snapshots very similar to daily trade volume difference. Query for our subgraph (https://api.thegraph.com/subgraphs/name/messari/looksrare-ethereum/graphql?query=%7B%0A++collectionDailySnapshots+%28where%3A+%7Bcollection%3A%220x4e1f41613c9084fdb9e34e11fae9412427480e56%22%7D%2C+orderBy%3Atimestamp%2C+orderDirection%3A+desc%29+%7B%0A++++dailyTradedItemCount%0A++++timestamp%0A++%7D%0A%7D) and for official looks subgraph (https://api.thegraph.com/subgraphs/name/looksrare/exchange/graphql?query=%7B%0A++collection+%28id%3A+%220x4e1f41613c9084fdb9e34e11fae9412427480e56%22%29+%7B%0A++++totalTransactions%0A++++dayData+%28orderBy%3A+date%2C+orderDirection%3A+desc%29+%7B%0A++++++dailyTransactions%0A++++++date%0A++++%7D%0A++%7D%0A%7D)
X2Y2 - Otherdeed (0x34d85c9cdeb23fa97cb08333b511ac86e1c4e258)	collectionDailySnapshot	royaltyFee	UNSURE	This royalty is technically right, but on X2Y2 there is no set royalties for creators, so should this technically be 0?
Opensea - BAYC (0xbc4ca0eda7647a8ab7c2061c2e118a18a936f13d)	collectionDailySnapshot	dailyTradeVolumeETH	UNSURE	Are we including USDC sales here? There is a USDC sale that is not looking like it is getting taken into account for 10/24/2022 (https://etherscan.io/tx/0x2564673d7718c8baeb889608d3eb3df7c715f3096c031dde77866e8b3aefa29b)
Opensea - BAYC (0xbc4ca0eda7647a8ab7c2061c2e118a18a936f13d)	collectionDailySnapshot	tradeCount	UNSURE	There is like a 6% deviation here, but I think its because we are not counting APE and USDC sales? If so, then this deviation is fine although we should probably be coutning all sales no matter what currency
Opensea - BAYC (0xbc4ca0eda7647a8ab7c2061c2e118a18a936f13d)	collectionDailySnapshot	dailyTradedItemCount	UNSURE	Same comments here as dailyTradeVolume looks like we are missing the USDC sale in the count,as subgraph is only recording the two W/ETH sales. Query - https://api.thegraph.com/subgraphs/name/messari/opensea-seaport-ethereum/graphql?query=%7B%0A++collectionDailySnapshots+%28where%3A+%7Bcollection%3A+%220xbc4ca0eda7647a8ab7c2061c2e118a18a936f13d%22%7D%2C+orderBy%3A+timestamp%2C+orderDirection%3Adesc%2C+first%3A+1%29+%7B%0A++++dailyMinSalePrice%0A++++dailyMaxSalePrice%0A++++dailyTradeVolumeETH%0A++++cumulativeTradeVolumeETH%0A++++timestamp%0A++++dailyTradedItemCount%0A++%7D%0A%7D

Trades

Transaction	Section	Status	Issue
OpenSea V1 - 0x606d9a36e8afb2a32365da4980d7bd491652a1d398230b3cc11119d03d6758eb	logIndex	UNSURE	Not sure if we are tracking a logIndex here. But looks like OrdersMatched is on 176 and we are recording null
OpenSea V2 - 0x5b2ec61b37395c3bdc1739d419c69cb04c2d4d2a9cb7d6a1df1a613d04c358df	logIndex	UNSURE	Same comments as transaction on Opensea V1. Looks like subgraph is recording logIndexas NULL here, but etherscan is showing 179 (https://etherscan.io/tx/0x5b2ec61b37395c3bdc1739d419c69cb04c2d4d2a9cb7d6a1df1a613d04c358df#eventlog)
OpenSea Seaport - 0x2564673d7718c8baeb889608d3eb3df7c715f3096c031dde77866e8b3aefa29b	ALL	NOT OK	This is the transaction in USDC and there is no trade being picked up by the subgraph. Etherscan - https://etherscan.io/tx/0x2564673d7718c8baeb889608d3eb3df7c715f3096c031dde77866e8b3aefa29b. Query - https://api.thegraph.com/subgraphs/name/messari/opensea-seaport-ethereum/graphql?query=%7B%0A++trades+%28where%3A+%7BtransactionHash%3A+%220x2564673d7718c8baeb889608d3eb3df7c715f3096c031dde77866e8b3aefa29b%22%7D%29+%7B%0A++++transactionHash%0A++%7D%0A%7D