dcos-docs-site icon indicating copy to clipboard operation
dcos-docs-site copied to clipboard

Added generate kubectl token page

Open alexchrisramos opened this issue 2 years ago • 5 comments

Jira Ticket

https://jira.d2iq.com/browse/D2IQ-78927

Description of changes being made

Part of epic https://jira.d2iq.com/browse/D2IQ-84949 [DOC] Feature Parity Work for Mediums and Low priority topics

Added the generate kubectl token page missing for 2.x that exist in 1.8 docs.

Preview

You can preview the docs build using the following URL, adding the PR # where specified: http://docs-d2iq-com-pr-4581.s3-website-us-west-2.amazonaws.com/

Checklist

  • [ ] Test all commands and procedures, if applicable.
  • [ ] Update all links if you are moving a page.
  • [ ] Add release date to Release Notes page in the following format: <Package> was released on <Day>, <Month> <Year> Example: Mesosphere® DC/OS™ 2.1.0 was released on 9, June 2020

See the contribution guidelines for more information.

alexchrisramos avatar Jul 15 '22 05:07 alexchrisramos

I have applied the requested changes into 2.1, 2.2 and 2.3. Thank you!

alexchrisramos avatar Jul 18 '22 04:07 alexchrisramos

Hey @alexchrisramos , I just noticed the package-lock.json file. Was that also intended to be part of the PR?

gvasquezvargas avatar Jul 18 '22 09:07 gvasquezvargas

@alexchrisramos we have multiple issues with this PR. there's a json file that can't be in there. And there are files that are not named index.md. so we can't merge this as-is.

cmastr avatar Jul 21 '22 19:07 cmastr

@alexchrisramos we have multiple issues with this PR. there's a json file that can't be in there. And there are files that are not named index.md. so we can't merge this as-is.

Ok, that's not true. The image files are fine. just the json file.

cmastr avatar Jul 22 '22 13:07 cmastr

I can take care of this json file - probably just a misfire when adding files to the commit from build or something.

msdolbey avatar Aug 16 '22 21:08 msdolbey