dcos-commons icon indicating copy to clipboard operation
dcos-commons copied to clipboard

Rlimit parameters are added to the Cassandra configuration.

Open AnandJat opened this issue 5 years ago • 4 comments

As per documentation of Cassandra I keep default values as follows: <cassandra_user> - memlock unlimited (done set default -1) <cassandra_user> - nofile 1048576 (Not touched as its already implemented in master) <cassandra_user> - nproc 32768 ( done) <cassandra_user> - Stack (for stack its not mentioned in document, so I use default values on which service successfully UP and running) All these values are user configurable.

AnandJat avatar May 31 '19 06:05 AnandJat

Hi @AnandJat,

Thanks for the additional changes, they look good. I'm adding a do-not-merge to the resource limit PRs for now because we might have to do some more additional work, based on my findings from the last couple of days. I'll share more details tomorrow.

mpereira avatar Jun 04 '19 20:06 mpereira

@mpereira do we need to resurrect this? Also curious what the blockers were...

kaiwalyajoshi avatar Jan 19 '20 08:01 kaiwalyajoshi

Hi @kaiwalyajoshi , @AnandJat was saying that a planning was going on to migrate Cassandra from dcos-commons that is why it was left abandoned. I think at that time only elastic was migrated out as a standalone also.

rishabh96b avatar Jan 20 '20 09:01 rishabh96b

Hey @kaiwalyajoshi,

The blocker was the SDK bug I found when implementing this for Elastic. The SDK fix was committed only after my last comment in this PR, and released even later.

From what I see, @AnandJat's implementation should work now assuming that it uses an SDK version that contains the fix mentioned above. It will be best to make sure that all tests are passing before merging this, though.

mpereira avatar Jan 20 '20 12:01 mpereira