meson icon indicating copy to clipboard operation
meson copied to clipboard

gnome: Fix expand-content-files in gtkdoc generation

Open inigomartinez opened this issue 4 years ago • 3 comments

Unlike content-files parameter, expand-content-files parameter doesn't allow to use generated target files, even though they are similar.

The same code used for content-files has been extracted and now is shared with expand-content-files so it can also used generated target files.

inigomartinez avatar Sep 07 '21 10:09 inigomartinez

Codecov Report

Attention: Patch coverage is 66.66667% with 8 lines in your changes missing coverage. Please review.

Project coverage is 66.85%. Comparing base (af8b55d) to head (09be873). Report is 3407 commits behind head on master.

Files Patch % Lines
mesonbuild/modules/gnome.py 66.66% 7 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9229      +/-   ##
==========================================
+ Coverage   66.84%   66.85%   +0.01%     
==========================================
  Files         386      386              
  Lines       84920    84940      +20     
  Branches    17527    17527              
==========================================
+ Hits        56765    56790      +25     
+ Misses      23363    23360       -3     
+ Partials     4792     4790       -2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 07 '21 11:09 codecov[bot]

Would be nice to have a test that uses generated files, or that even uses expand_content_files at all.

Also this parameter to gnome.gtkdoc() is completely undocumented. :(

eli-schwartz avatar Sep 09 '21 08:09 eli-schwartz

Would be nice to have a test that uses generated files, or that even uses expand_content_files at all.

Also this parameter to gnome.gtkdoc() is completely undocumented. :(

I don't have enough knowledge to add a test using expand_content_files at the moment. I have used it only to port applications/libraries using it.

However, I've added it to the documentation so it will be present for anyone looking for the available parameters.

inigomartinez avatar Sep 09 '21 09:09 inigomartinez

Codecov Report

Attention: Patch coverage is 66.66667% with 8 lines in your changes missing coverage. Please review.

Project coverage is 66.85%. Comparing base (af8b55d) to head (09be873). Report is 3553 commits behind head on master.

Files with missing lines Patch % Lines
mesonbuild/modules/gnome.py 66.66% 7 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9229      +/-   ##
==========================================
+ Coverage   66.84%   66.85%   +0.01%     
==========================================
  Files         386      386              
  Lines       84920    84940      +20     
  Branches    17527    17527              
==========================================
+ Hits        56765    56790      +25     
+ Misses      23363    23360       -3     
+ Partials     4792     4790       -2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Sep 26 '24 16:09 codecov-commenter