meson icon indicating copy to clipboard operation
meson copied to clipboard

dependencies: find extraframeworks on case-sensitive filesystems

Open reckenrode opened this issue 10 months ago • 2 comments

This PR fixes a test failure on case-sensitive filesystems when a CMake dependency is turned into an Apple framework. I ran into this issue while working on the Darwin stdenv in nixpkgs after Meson was updated to 1.4.0 because my Nix store is installed on a case-sensitive APFS volume.

The extraframeworks search logic was already case insensitive. The fix was to use the match’s actual name instead of the one that was requested. I included a test, though the original test for https://github.com/mesonbuild/meson/pull/12181 also serves as a test for case-sensitive filesystems.

I found https://github.com/mesonbuild/meson/issues/12480 in the issue tracker, but the scope of fixing that seems like a much larger fix and wouldn’t address the issue I encountered building the Darwin stdenv in nixpkgs.

reckenrode avatar Apr 03 '24 21:04 reckenrode

I fixed the mypy lint failure.

reckenrode avatar Apr 03 '24 22:04 reckenrode

ci failures seem irrelevant

bruchar1 avatar Apr 05 '24 12:04 bruchar1

Is there anything else needing to be done to move this forward after approval?

reckenrode avatar Jun 26 '24 11:06 reckenrode

@jpakkane If I'm following along correctly, it sounds like this would make changes such as #13349 unnecessary :)

abathur avatar Jun 30 '24 19:06 abathur

We are currently in RC freeze so only regression bugfixes are permitted.

jpakkane avatar Jun 30 '24 20:06 jpakkane