meson icon indicating copy to clipboard operation
meson copied to clipboard

Do not drop StructuredSources from internal dependencies

Open xclaesse opened this issue 3 years ago • 3 comments

xclaesse avatar Sep 23 '22 18:09 xclaesse

This pull request introduces 2 alerts when merging 181144d751c5397302d84f7e7727aa961c7b0630 into bed5b31079823f1f2a05b43abd5b148d17c777aa - view on LGTM.com

new alerts:

  • 2 for Wrong number of arguments in a class instantiation

lgtm-com[bot] avatar Sep 23 '22 18:09 lgtm-com[bot]

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 44.28%. Comparing base (bed5b31) to head (8c4b028). Report is 1917 commits behind head on master.

Files Patch % Lines
mesonbuild/modules/rust.py 0.00% 3 Missing :warning:
mesonbuild/ast/introspection.py 0.00% 1 Missing :warning:

:exclamation: There is a different number of reports uploaded between BASE (bed5b31) and HEAD (8c4b028). Click for more details.

HEAD has 16 uploads less than BASE
Flag BASE (bed5b31) HEAD (8c4b028)
19 3
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #10846       +/-   ##
===========================================
- Coverage   68.76%   44.28%   -24.48%     
===========================================
  Files         404      404               
  Lines       86651    86197      -454     
  Branches    19195    18377      -818     
===========================================
- Hits        59585    38172    -21413     
- Misses      22606    44488    +21882     
+ Partials     4460     3537      -923     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 23 '22 18:09 codecov[bot]

@dcbaker wanna take a moment to review this if you get a chance since you implemented this. Perhaps this might be important to Rust? Not sure.

tristan957 avatar May 23 '23 23:05 tristan957