meson-python icon indicating copy to clipboard operation
meson-python copied to clipboard

CI: fix docs build and deploy workflow

Open dnicolodi opened this issue 10 months ago • 4 comments

Did I ever complain about the GitHub Actions documentation being an horrible mess?

dnicolodi avatar Apr 17 '24 11:04 dnicolodi

No, I haven't tested this locally and I run out of time for the moment. I was hoping that someone with more experience with GitHub Actions could comment on the validity of what I've done here. I'll test this in my fork. Anyhow, for some reason the GitHub Actions runners haven't pick up this PR...

dnicolodi avatar Apr 17 '24 12:04 dnicolodi

Ah okay. Let me compare with what works in another project. I have a fair amount of experience with GHA, but this kind of thing is mostly trial-and-error rather than understand-then-do unfortunately.

The updated docs are up on https://mesonbuild.com/meson-python/, so this isn't a burning issue I think.

rgommers avatar Apr 17 '24 12:04 rgommers

Hi, I just looked at the changes made here, and I think they should work. 👍 Just to note that github.ref on tags is heads/refs/<name of the tag> and not just <name of the tag>, so that could be the only possible place where this can break.

agriyakhetarpal avatar Apr 17 '24 12:04 agriyakhetarpal

The updated docs are up

I triggered the workflow manually to publish them. I was not sure whether the issue was with the trigger or with the job definition, so doing that ruled out the latter.

dnicolodi avatar Apr 17 '24 12:04 dnicolodi

I've testes this and it works as expected. It needs an adjustment to the environment protection rules in the project settings to be able to deploy the documentation from a tag. I've already done this.

dnicolodi avatar Apr 25 '24 16:04 dnicolodi