i3lock-fancy
i3lock-fancy copied to clipboard
meskarune
Not displaying properly on dual monitors
It seems that your script is not working for dual monitors. The lock is displayed in the gap between the monitors while the type feedback indicator is displayed twice in the center of each screen. Would be great to have support for dual monitors!
I don't have dual monitors to test on, but I'll see what I can do. Thanks for reporting this!
I experience this bug as well, I'll see if I can fix it on my own and then submit a pull request.
edit: PR submitted.
I think somone has made effort to solve this: https://github.com/guimeira/i3lock-fancy-multimonitor so we can close this for now.
I have a fix for this in the works, so I'm going to go ahead and reopen, but thanks for the link! I'm happy other people have been able to use my idea/code :dancer:
Ok, preliminary dual monitor support is up in the dualmonitor branch. \o/
I still need to fix up dark/light detection so it works for each screen and make all the text take up the same amount of space so I can center it for all languages. Unfortunately this could cause some line wrapping for really long text, but that's very unlikely to happen unless someone edits the text. (or I add a custom text option...)
In the dual monitor branch I switched to token light lock icon which has a shadow behind it and shows up on dark and light backgrounds. I am working on making text with light grey fill and a dark stroke and/or shadow so it will also stand out on both dark/light backgrounds. This reduces the run time as there isn't a check for light/dark. I need to work on text centering more. I think there is a way to detect pixel length of text so the centering is more accurate.
Here are screenshots for the dual monitors script with Open-Sans-Light set as the font. I'm using text shadow to make the text readable for light/dark and using a grey icon with shadow. Any suggestions/recommendations would be appreciated.
Just tested this branch out on my dual monitor setup (I don't use it very often or I would've tried it out sooner) and what's in the current dualmonitors works great for me.
Not yet @leshow there are still some things I need to figure out. Primarily if there is some way to do color detection or if I should drop that feature? I'm not sure what the right way to handle it is. I really need to update the dual monitors branch with features added in the main branch.
@meskarune any chance for this being merged into master this year? I'm not sure whether I should install master onto a laptop and manually dualmonitors branch onto my desktops, or move forward with a fork. What would be your recommendation? Modifying PKGBUILD to install from custom branches on multiple machines is kinda painful.
Hi! @meskarune what kind of help do you need? I have two monitors and I want to help.
I have checked https://github.com/meskarune/i3lock-fancy/pull/87/files PR - it works fine.
@patrick96 Your version for dual monitors works fine. I have only one question. Script beeps twice on executing. Do you have any thoughts what may the reason of it?