Nick Porcino

Results 625 comments of Nick Porcino

Ok, I worked through the cmake script, and here's what I found. If you set `PXR_USE_INTERNAL_BOOST_PYTHON` to zero, then the linked library is specified in CMake via `${Boost_PYTHON_LIBRARY}`. working through...

This is a reasonable suggestion, we could do that. Are you interested in submitting a PR? I don't personally work with debug python builds on windows, so I'm not really...

Would you like to submit a PR for that? Or we can patch it; looks like a good addition.

Thanks! The diff is so much easier to look at now :)

What's the current status? The latest revisions look good from my perspective. I'm looking forward to the proposal being merged.

I believe it doesn't make sense to scale the color like this? ``` ``` I think you want to use "raw" as the color space here because you are intending...

I think the correction needs to be done in graph, rather than at the renderer. It seems like if you want to do conversions at renderer load time you would...

For the purposes of code review, could you elaborate a little on this ~ > It leaves the existing binding API in place for backwards-compatibility; there's no overlap between the...

I'm happy if we land this; I haven't got more feedback to give, seems like playing with it for a while is a good next step.

I'm not aware of any objections to turning on ARC all the time on Apple, or on non-Apple deployments of Swift or ObjC.