web icon indicating copy to clipboard operation
web copied to clipboard

Support for cmdk v1.0.0

Open NuclearConsent opened this issue 1 year ago • 3 comments

Fixes #173

Package cmdk was updated to v1.0.0 with breaking changes. A couple things needed to be updated to support the major version.

This pull request does the following:

  • Update data-disabled to true in Command.tsx to support cmdk v1
    • Help found here: https://github.com/shadcn-ui/ui/issues/2944#issuecomment-1985153126)
  • Updated this app to use latest Meshtastic.js version (2.3.2-0)
  • Bumped this app version to 2.2.20

I did not see any contributing guidelines. Please let me know if anything needs to be changed.

NuclearConsent avatar Mar 26 '24 19:03 NuclearConsent

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Mar 26 '24 19:03 CLAassistant

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Mar 26 '24 19:03 CLAassistant

Hi, thanks for the PR, could you please revert the version bump (needs to be in sync with the firmware) and I'll get this merged

sachaw avatar Apr 26 '24 14:04 sachaw