[Bug]: Defining MESHTASTIC_EXCLUDE_GPS breaks ESP32 build

[ndoo]

Category

Other

Hardware

T-Lora v2 1.6

Is this bug report about any UI component firmware like InkHUD or Meshtatic UI (MUI)?

• [ ] Meshtastic UI aka MUI colorTFT
• [ ] InkHUD ePaper
• [ ] OLED slide UI on any display

Firmware Version

HEAD

Description

Adding -DMESHTASTIC_EXCLUDE_GPS to build_flags of tlora_v2-1-1_6 breaks build:

src/graphics/draw/MenuHandler.cpp: In lambda function:
src/graphics/draw/MenuHandler.cpp:150:49: error: 'default_mqtt_root' was not declared in this scope

I haven’t had the time yet to investigate further but just logging it here in case myself or anyone else wishes to try, I suspect there is a missing #include Default.h somewhere.

Relevant log output

[ndoo]

Adding #include "Default.h" after #if HAS_SCREEN in MenuHandler.cpp fixes this.

I won't have time to raise a PR for a while, but if anyone has time to test this, it should be a simple fix.

[Xaositek]

I think we discovered this at some point in the "multi message Storage" track of work as I see we've corrected this here.

https://github.com/meshtastic/firmware/pull/8182