firmware icon indicating copy to clipboard operation
firmware copied to clipboard

Replace blocking delay for wifi reconnect with non-blocking to keep button/display interactivity

Open mattster98 opened this issue 6 months ago • 4 comments

🙏 Thank you for sending in a pull request, here's some tips to get started!

Full disclosure - I used copilot to author this change. Annoying thing I've been hoping to solve and it appeared quick/easy.

🤝 Attestations

  • [X] I have tested that my proposed changes behave as described.
  • [ X] I have tested that my proposed changes do not cause any obvious regressions on the following devices:
    • [X] Heltec (Lora32) V3
    • [ ] LilyGo T-Deck
    • [ ] LilyGo T-Beam
    • [ ] RAK WisBlock 4631
    • [ ] Seeed Studio T-1000E tracker card
    • [ ] Other (please specify below)

mattster98 avatar Jun 07 '25 22:06 mattster98

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jun 07 '25 22:06 CLAassistant

Hi @mattster98 , are you familar with trunk? We use it for linting. If you use vscode you can install the plugin and it'll automatically fix that check that's failing

fifieldt avatar Jun 08 '25 04:06 fifieldt

I am not but I'll take a look. I'd like to figure it out as there are a couple other changes I'd like to make as well.

mattster98 avatar Jun 08 '25 11:06 mattster98

Sorry, because I don't know what I'm doing I have made some other changes in the github web interface I thought would remain local to my fork for testing and it has attached them here. I got vscode going and did my best to straighten it out and address the changes. Please take another look. Thank you for your patience with me.

mattster98 avatar Jun 17 '25 14:06 mattster98

Looks good to me now. Can you revert the changes to the yml files?

GUVWAF avatar Jun 19 '25 16:06 GUVWAF

Looks good to me now. Can you revert the changes to the yml files?

Done - starting to get the hang of this. Learning the hard way unfortunately.

mattster98 avatar Jun 19 '25 17:06 mattster98