firmware icon indicating copy to clipboard operation
firmware copied to clipboard

Issue5194 external notification module refactor

Open Blake-Latchford opened this issue 1 year ago • 2 comments

Centralize ExternalNotificationModule LED handling

This PR attemtps to take a small step towards addressing issue 5194 by de-duplicating LED handling code within ExternalNotificationModule. I also refactored the color state code around an alpha channel approach.

Blake-Latchford avatar Nov 17 '24 16:11 Blake-Latchford

Flashed to my Heltek v3, and I updated the variant locally to drive some unused pins as LEDs. Logging verified that on startup the LED was disabled. I'm currently trying to figure out how to simulate message reception given that I only own one node right now.

INFO  | ??:??:?? 1 [ExternalNotification] Turning off external notification: 
DEBUG | ??:??:?? 1 [ExternalNotification] setLEDs red=0, green=0, blue=0
INFO  | ??:??:?? 1 [ExternalNotification] 0 
DEBUG | ??:??:?? 1 [ExternalNotification] setLEDs red=0, green=0, blue=0
INFO  | ??:??:?? 1 [ExternalNotification] 1 
DEBUG | ??:??:?? 1 [ExternalNotification] setLEDs red=0, green=0, blue=0
INFO  | ??:??:?? 1 [ExternalNotification] 2
INFO  | ??:??:?? 1 [ExternalNotification] 

Blake-Latchford avatar Nov 17 '24 16:11 Blake-Latchford

Hi @Blake-Latchford , how's this one going? Need any help?

fifieldt avatar Dec 23 '24 23:12 fifieldt