firmware icon indicating copy to clipboard operation
firmware copied to clipboard
verified publisher icon meshtastic

Switch to actually maintained thingsboard pubsubclient

Open thebentern opened this issue 1 year ago • 3 comments

Our MQTT library of choice is without a maintainer and hasn't been updated in 4 years. Pretty depressing thread: https://github.com/knolleary/pubsubclient/issues/1045

Thingsboard has taken up the most involved fork of this and seems to have already integrated some good changes, even as recent as 2 weeks ago.

thebentern avatar Oct 31 '24 10:10 thebentern

Did not work out of the box. Marking as draft :-(

thebentern avatar Nov 01 '24 15:11 thebentern

I read the background and it does look like this is the one to move to

fifieldt avatar Nov 02 '24 00:11 fifieldt

https://github.com/thingsboard/pubsubclient/releases/tag/v2.11.0 fixed an issue with sending the credentials in the initial connection. Maybe this works now? It passed all the unit tests from #5724 and seems to be working on my heltec-v3 with my local MQTT server.

I'll send them a PR and see if we can make some of the methods virtual, for use in those tests.

esev avatar Jan 03 '25 02:01 esev

thingsboard/pubsubclient has been updated to include @esev's changes :tada: https://github.com/thingsboard/pubsubclient/compare/v2.11.0...v2.12.1

vidplace7 avatar Apr 15 '25 14:04 vidplace7