firmware icon indicating copy to clipboard operation
firmware copied to clipboard

RAK_4631 PRIVATE_HW definition is fundamentally broken (accoring to closed issue)

Open jbuck2005 opened this issue 1 year ago • 1 comments

          > RAK_4631 especially is tied to a lot of things inside the source code that makes the module work as expected. You can add another define to act upon in macro guards but please never replace it. If you want to signal a'private hw' you can add your macro to the architecture.h for nrf52 platform.

Why would this have worked previously though? (changing from RAK_4631 to PRIVATE_HW in the platformio.ini)

Further, what you are suggestion actually is contrary to what is posted as part of the development documentaion. https://meshtastic.org/docs/development/firmware/build/

Originally posted by @jbuck2005 in https://github.com/meshtastic/firmware/issues/5107#issuecomment-2425185009

jbuck2005 avatar Oct 20 '24 22:10 jbuck2005

I maintain that this is a bug and what was proposed in closing the original issue is NOT appropriate and directly conflicts with the documentation.

jbuck2005 avatar Oct 20 '24 22:10 jbuck2005