Meshtastic-gui-installer icon indicating copy to clipboard operation
Meshtastic-gui-installer copied to clipboard

review/fix translated values

Open mkinney opened this issue 3 years ago • 25 comments

Create PR for translated values in fields.json. https://github.com/meshtastic/Meshtastic-gui-installer/blob/master/meshtastic_flasher/fields.json

The initial values were created using deepl.com, however, a native speaker might translate the values to something more reasonable.

No coding necessary for this task. Just github PRs and your native language knowledge.

Update: The file is a json file, which makes it hard to process some languages like Russian, Japanese, and Chinese. Since two of those languages have volunteers to process, I'll post the Japanese file here: ja.txt

mkinney avatar Mar 14 '22 10:03 mkinney

These languages have been reviewed by a native speaker:

  • [X] Deutsch / German / "de" (Caveman99)
  • [X] Español / Spanish / "es" Daroes433
  • [ ] Français / French / "fr" - Kongdunio?
  • [ ] Italiano / Italian / "it" - first part of the file has been reviewed (Lollo)
  • [X] Polski / Polish / "pl" - one quick pass was made (maciej), another pass was made by wkawecki
  • [X] 中国 / Chinese / "zh" - laosb
  • [X] русский / Russian "ru" - RocketRun
  • [ ] 日本語 / Japanese "ja"
  • [ ] Română / Romanian "ro" - cavemantaco - about 2/3rds reviewed/updated
  • [X] Eesti keel / Estonian "et" - Le Andre

mkinney avatar Mar 14 '22 16:03 mkinney

This issue has been mentioned on Meshtastic. There might be relevant details there:

https://meshtastic.discourse.group/t/anyone-know-chinese-zh-or-espanol-spanish-es-or-japanese-ja/5363/1

geeksville avatar Mar 15 '22 19:03 geeksville

I might be able to review Chinese translation. Not an EE/Radio guy though, so I won't be able to offer much advice on some deep tech terms.

laosb avatar Mar 16 '22 06:03 laosb

One question: Does the JSON have to use unicode escape strings for non-ASCII? Since Chinese characters are non-ASCII, it's very hard to inspect the JSON file directly on GitHub web interface.

laosb avatar Mar 16 '22 06:03 laosb

That's great! @laosb If there's anything technical or you don't understand, feel free to either skip that one or ask questions.

I wrote a simple script to get around that bin/show_entries_for_lang.py zh > zh.txt

Here's the file: zh.txt

Can you make changes to that file directly, then add an updated file to a comment?

Edit: We found that "canned messages" does not really translate well. Perhaps use "predetermined messages" when you see that text, since that is what the module is intended to do.

mkinney avatar Mar 16 '22 07:03 mkinney

That's great! @laosb If there's anything technical or you don't understand, feel free to either skip that one or ask questions.

I wrote a simple script to get around that bin/show_entries_for_lang.py zh > zh.txt

Here's the file:

zh.txt

Can you make changes to that file directly, then add an updated file to a comment?

Edit: We found that "canned messages" does not really translate well. Perhaps use "predetermined messages" when you see that text, since that is what the module is intended to do.

That's good, I will try to review this later today.

laosb avatar Mar 16 '22 10:03 laosb

Hi, I am a native Spanish, I can proofread the text

Daroes433 avatar Mar 16 '22 10:03 Daroes433

Hi, I am a native Spanish, I can proofread the text

Great! Can you do a pull request for any changes?

mkinney avatar Mar 16 '22 14:03 mkinney

How do you do this? (I'm new) I was making changes to later make a propose changes. It's okay like that?

Daroes433 avatar Mar 16 '22 14:03 Daroes433

How do you do this? (I'm new) I was making changes to later make a propose changes. It's okay like that?

How about using this file to review and edit your changes? es.txt

When done, add the updated file to a comment? (just drag file into the comment section)

mkinney avatar Mar 16 '22 14:03 mkinney

Great! One question, there are signs in Spanish (for example ñ ¿ ´) that must be activated or notified of the use of utf-8 in order for them to appear. Will the text appear only in the installer GUI or also on the device screen? Thank you

Daroes433 avatar Mar 16 '22 15:03 Daroes433

Great! One question, there are signs in Spanish (for example ñ ¿ ´) that must be activated or notified of the use of utf-8 in order for them to appear. Will the text appear only in the installer GUI or also on the device screen? Thank you

These changes are for the Meshtastic-flasher program. You should be able to use your normal text editor, that has those specific signs. I think the Meshtastic device needs more work to handle Unicode on the displayed messages. However, the clients like Android and iOS might handle them ok, but I’m not 100% sure. You can test it yourself. 😀

mkinney avatar Mar 16 '22 15:03 mkinney

@mkinney

A bit more effort than I anticipated, but here we are:

zh.txt

Some problems to note:

  • The field:coding_rate key:description has an example explaining the concept of denominator. However, in the original English text, it says ie for 4/8, the value is 8. 5/8 the value is 5, which is not correct. I believe the correct expression would be ie for 4/8, the value is 8. 4/5 the value is 5. Didn't touch the original text but the translation is corrected.
  • The phrasing field:ext_notification_module_active key:description is misleading to me (and DeepL it seems). It seems to imply that the device generates a notification message when the set GPIO is active-high / active-low, where it's actually the very opposite. I would recommend change the wording a bit to clarify.

And it would be better to make this version of Chinese zh-cn since it's done according to Simplified Chinese in Mainland China. That will make space for other variants, like zh-tw which is a different dialect of Chinese used in Taiwan. I can help with zh-tw variant though it would be better if some native speakers of this dialect is interested in doing it.

laosb avatar Mar 16 '22 15:03 laosb

@laosb Thank you for your efforts! I really appreciate it.

I've created a new issue to look into the coding_rate. Thanks for catching that.

I've also created an issue in deepl about the "Simplified" comment. (makes sense to me)

I'll take a look at the file you uploaded and see if I have any questions. Again, THANKS!. :-)

mkinney avatar Mar 16 '22 16:03 mkinney

Corrections are already made. Greetings es.txt

Daroes433 avatar Mar 16 '22 17:03 Daroes433

Le Andre to review the Estonian: et.txt

Cavemantaco to review the Romanian: ro.txt

mkinney avatar Mar 17 '22 21:03 mkinney

The updated Russian (after review) by Dmitri: ru2.txt

mkinney avatar Mar 21 '22 15:03 mkinney

Updated Estonian

mkinney avatar Mar 30 '22 17:03 mkinney

Updated what work was done on Romanian ro2.txt

mkinney avatar Mar 30 '22 18:03 mkinney

Merged in some French updates from Kongduino.

Since there are still some changes, had to create new entries.

mkinney avatar Mar 31 '22 18:03 mkinney

Here are updated files, if anyone wants to work on an individual language and they do not want to do pull requests:

ja.txt ro.txt pl.txt fr.txt it.txt

mkinney avatar Mar 31 '22 18:03 mkinney

Correction for Polish language. pl.txt

wkawecki avatar Apr 13 '22 15:04 wkawecki

Correction for Polish language.

It looks like that file is the same as the file in the comment. Did you upload the file where changes were made?

mkinney avatar Apr 13 '22 18:04 mkinney

Sorry, my mistake - wrong file. This should be correct pl.txt

wkawecki avatar Apr 13 '22 20:04 wkawecki

No worries. Thank you.

mkinney avatar Apr 14 '22 00:04 mkinney