Meshtastic-Apple icon indicating copy to clipboard operation
Meshtastic-Apple copied to clipboard

🐞 [Bug]: CLIENT_BASE DMs should not auto-favorite

Open thebentern opened this issue 1 month ago • 1 comments

Before submitting

  • [x] I have searched existing issues to make sure this bug hasn't already been reported
  • [x] I have updated to the latest version of the software to verify the issue still exists

Firmware Version

2.7.X

What did you do?

Currently I believe we have implemented automatic flavoriting upon DMing another node in all app platforms. This is generally considered desirable behavior as it ensures that the public keys are retained in the nodedb of the device. However, we have one context where this is extremely problematic, which is in the CLIENT_BASE role. In this role, we would be unintentionally creating routing issues for nodes which are not explicitly favorited by the user for relay out of their home base nodes.

Expected Behavior

See above

Current Behavior

No response

Participation

  • [ ] I am willing to submit a pull request for this issue.

Additional comments

No response

Code of Conduct

  • [x] I agree to follow this project's Code of Conduct

thebentern avatar Nov 05 '25 14:11 thebentern

See my comment here https://github.com/meshtastic/firmware/issues/8556#issuecomment-3492967334 -- I think it's happening in the firmware, not explicitly in the iOS client.

compumike avatar Nov 05 '25 19:11 compumike