Meshtastic-Android icon indicating copy to clipboard operation
Meshtastic-Android copied to clipboard

Error: Code scanner module is not supported on current Google Play Services version, please upgrade

Open mc-hamster opened this issue 3 years ago • 1 comments

I have 1.3.30 installed on an LG L322DL running Android 10 and when I try to scan a QR code, I get the error message:

"Code scanner module is not supported on current Google Play Services version, please upgrade"

I clicked the Report Bug button at 10:13pm PT.

Reproduced on another device, clicked Report Bug on that device at 10:40pm PT.

mc-hamster avatar Aug 10 '22 05:08 mc-hamster

QR scanner doesn't work at all on phones without google play services (even with microg), maybe its worth swapping to a different QR scanning library.

EDIT: open-source QR scanner libraries were harder to come by than I expected. The only decently sized project I found was https://github.com/journeyapps/zxing-android-embedded. It would be easier to leave as is and for people without google play services do like other open-source apps such as f-droid do: have URL handler intent allowing another QR scanner (e.g. https://github.com/SecUSo/privacy-friendly-qr-scanner) to open URL in the app.

Douile avatar Aug 11 '22 13:08 Douile

@mc-hamster thanks for the report. fix is incoming.

@Douile thanks for mentioning aosp/microg. the app already uses zxing and handles channel url intents. play services code scanner is only meant for play store installs, so that needs fixing.

andrekir avatar Aug 14 '22 11:08 andrekir

Oh mb i should have read the code instead of assuming. Sorry for off topic but is there a build flag or something i need to turn on to use zxing instead of play services?

Douile avatar Aug 14 '22 22:08 Douile

#461 should fix it. if you want to try the debug apk from that PR you can find it here.

andrekir avatar Aug 14 '22 23:08 andrekir

@mc-hamster when you have the time, please confirm if 1.3.38 release fixes this issue for you.

andrekir avatar Aug 16 '22 23:08 andrekir