Meshtastic-Android icon indicating copy to clipboard operation
Meshtastic-Android copied to clipboard

Feat request neighbours

Open DaneEvans opened this issue 1 month ago • 2 comments

Requires https://github.com/meshtastic/firmware/pull/8523

Adds a button to node details to request neighbours from a node.

DaneEvans avatar Nov 15 '25 11:11 DaneEvans

Codecov Report

:x: Patch coverage is 0% with 183 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 0.60%. Comparing base (3e3dfe0) to head (fae4a51). :warning: Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...in/java/com/geeksville/mesh/service/MeshService.kt 0.00% 76 Missing :warning:
app/src/main/java/com/geeksville/mesh/ui/Main.kt 0.00% 61 Missing :warning:
...eshtastic/feature/node/component/CooldownButton.kt 0.00% 17 Missing :warning:
...htastic/feature/node/detail/NodeDetailViewModel.kt 0.00% 9 Missing :warning:
...meshtastic/feature/node/component/DeviceActions.kt 0.00% 5 Missing :warning:
...stic/feature/node/component/RemoteDeviceActions.kt 0.00% 4 Missing :warning:
...tic/feature/map/cluster/RadiusMarkerClusterer.java 0.00% 3 Missing :warning:
...g/meshtastic/feature/node/detail/NodeDetailList.kt 0.00% 3 Missing :warning:
...src/main/java/com/geeksville/mesh/model/UIState.kt 0.00% 2 Missing :warning:
...meshtastic/feature/node/detail/NodeDetailScreen.kt 0.00% 2 Missing :warning:
... and 1 more
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #3709      +/-   ##
========================================
- Coverage   0.60%   0.60%   -0.01%     
========================================
  Files        406     406              
  Lines      24283   24457     +174     
  Branches    3121    3153      +32     
========================================
  Hits         148     148              
- Misses     24112   24286     +174     
  Partials      23      23              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Dec 06 '25 11:12 codecov[bot]

It also pops up on every Neighbour packet, or when one arrives while the app is closed.

I need to fix that. Was hoping to test it on new FW, but then the new FW didn't play nice.

DaneEvans avatar Dec 06 '25 13:12 DaneEvans

Calling this ready - I'd like to suggest that we flag an 'info' tooltip or similar for menu items.

  • This (only new FW targets, and needs to be turned on etc.) ,
  • metadata (wtf is that to the uninitiated) ,
  • remote admin (why it might fail / how to set up ) and a few others could do with it, but it'll be a feature that we have to add to the listItems in a coherent way.

DaneEvans avatar Dec 21 '25 09:12 DaneEvans

This is a pretty expensive action, and does not really work with recent firmware. Hard on the mesh and will fail a lot, probably not a great feature as the firmware works currently.

garthvh avatar Dec 22 '25 06:12 garthvh