meshkit icon indicating copy to clipboard operation
meshkit copied to clipboard

folder nats.go line #101 updated and #796 issue is resolved

Open ChrissHenilston777 opened this issue 2 months ago • 8 comments

Description

This PR fixes #796

Notes for Reviewers logrus.InfoLevel is the specific level of verbosity.where current loglevel hardcoded to 4 which is the constant of the logrus level.to make it readable for programmers and contributor ,i updated from the loglevel 4 to logrus.Infolevel. folder nats.go line #101 updated and #796 issue is resolved

Signed commits

  • [ ] Yes, I signed my commits.
  • [ ] logrus-constant

ChrissHenilston777 avatar Sep 11 '25 21:09 ChrissHenilston777

Yay, your first pull request! :thumbsup: A contributor will be by to give feedback soon. In the meantime, you can find updates in the #github-notifications channel in the community Slack. Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while performing a commit.

welcome[bot] avatar Sep 11 '25 21:09 welcome[bot]

🚨 Alert! Git Police! We couldn’t help but notice that one or more of your commits is missing a sign-off. A what? A commit sign-off (your email address).

To amend the commits in this PR with your signoff using the instructions provided in the DCO check.

To configure your dev environment to automatically signoff on your commits in the future, see these instructions.


        Be sure to join the community, if you haven't yet and please leave a :star: star on the project :smile:

github-actions[bot] avatar Sep 11 '25 21:09 github-actions[bot]

you did not sign off your commit uncheck in the the description

lekaf974 avatar Sep 11 '25 21:09 lekaf974

Thanks for the feedback! My goal with this PR was to address issue #796 by removing the magic number. Making the log level configurable is a great idea for a future enhancement. If that's the desired direction, I'd be happy to open a new issue for it

ChrissHenilston777 avatar Sep 11 '25 22:09 ChrissHenilston777

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Oct 28 '25 07:10 stale[bot]

@ChrissHenilston777 could you resync with master and fix latest comment to get it merged ?

lekaf974 avatar Oct 31 '25 20:10 lekaf974

Ok fine I will be fix it by the evening.

ChrissHenilston777 avatar Nov 01 '25 06:11 ChrissHenilston777

there is also dco that needs to be fix

lekaf974 avatar Nov 03 '25 00:11 lekaf974