meshkit icon indicating copy to clipboard operation
meshkit copied to clipboard

fix: resolve warnings and improve file extraction logic

Open ShigrafS opened this issue 4 months ago • 6 comments

Closes: #755

Description

This draft PR addresses and aims to fix all existing errors, warnings, and lint issues throughout the codebase to improve overall code quality, stability, and maintainability. It includes fixes in utilities, sanitization, and other core packages with the following key changes:

  • Fixed improper resource handling such as missing or misused defer statements (e.g., closing files and readers).

This PR serves as a foundation for a cleaner, more maintainable codebase by systematically resolving technical debt and improving developer experience.

Notes for Reviewers

  • This is a draft PR and may require iterative reviews and tests.
  • Some changes are large refactors; please pay close attention to file handling and error wrapping.
  • Unit tests and integration tests should be run to ensure no regressions.
  • Feedback on potential edge cases or improvements in error messaging is welcome.
  • Additional lint rules might be applied progressively in subsequent PRs.

[Signed commits](../CONTRIBUTING.md#signing-off-on-commits-developer-certificate-of-origin)

  • [x] Yes, I signed my commits.

ShigrafS avatar Jul 27 '25 09:07 ShigrafS

Yay, your first pull request! :thumbsup: A contributor will be by to give feedback soon. In the meantime, you can find updates in the #github-notifications channel in the community Slack. Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while performing a commit.

welcome[bot] avatar Jul 27 '25 09:07 welcome[bot]

Thank you for your contribution!! If this work is complete, this is a good item to add to the weekly Meshery Development meeting agenda. You can add this item in the doc, attend, and present it. Meeting details at https://meet.layer5.io/meshery.

vr-varad avatar Aug 05 '25 21:08 vr-varad

Hi @vr-varad Actually the issue that this PR is trying to solve has a varied scope. Therefore, I'm planning to reduce the scope of this PR and fix the original issue with multiple PRs. Additionally, there are more changes that needs to be pushed to this branch, after I decide on my approach.

Please let me know your opinions. Thanks!

ShigrafS avatar Aug 06 '25 13:08 ShigrafS

@ShigrafS I strongly suggest you create several PRs and fix issues 1 by 1 please, this will help reviewers

lekaf974 avatar Sep 05 '25 20:09 lekaf974

@ShigrafS sorry for dealy and thanks for the work done, added small comments

lekaf974 avatar Sep 16 '25 01:09 lekaf974

@lekaf974 Apologies for the delay. I've made the necessary changes. Kindly review it. Thank you.

ShigrafS avatar Sep 21 '25 17:09 ShigrafS

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Nov 07 '25 05:11 stale[bot]

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.

stale[bot] avatar Nov 18 '25 06:11 stale[bot]