meshkit icon indicating copy to clipboard operation
meshkit copied to clipboard
verified publisher icon meshery

Bug/srivastavasujay/issue#677

Open srivastavasujay opened this issue 11 months ago • 4 comments

Description

This PR fixes #677

  1. broker/nats/nats.go Removed deprecated nats.EncodedConn and related methods: Replaced nats.EncodedConn with nats.Conn. Removed nats.NewEncodedConn and handled message encoding manually using encoding/json. Updated methods to use nats.Conn for publishing and subscribing messages.Fix Subscribe method signature in Nats struct to match broker.Handler interface

  2. models/meshmodel/core/policies/rego_policy_relationship.go: Updated OPA packages to use v1 versions:

  3. models/oci/oci.go Replaced deprecated oras.PackManifestVersion1_1_RC4

Notes for Reviewers

Signed commits

  • [x] Yes, I signed my commits.

srivastavasujay avatar Feb 14 '25 20:02 srivastavasujay

Thank you, @srivastavasujay! 👍

leecalcote avatar Feb 21 '25 18:02 leecalcote

Thank you for this, @srivastavasujay 👏

leecalcote avatar Mar 06 '25 21:03 leecalcote

@srivastavasujay, I wonder if you can assist in getting the two failing ❌ build checks (which are not necessarily related to your code changes) rectified and our builds here passing. ✅

What do you say? 😁

leecalcote avatar Mar 06 '25 21:03 leecalcote

Here's are the issues you can try @srivastavasujay (regarding what @leecalcote mentioned above)

  1. https://github.com/meshery/meshkit/issues/693
  2. https://github.com/meshery/meshkit/issues/642

riyaa14 avatar Mar 06 '25 21:03 riyaa14

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 22 '25 00:04 stale[bot]

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.

stale[bot] avatar May 02 '25 00:05 stale[bot]