meshkit icon indicating copy to clipboard operation
meshkit copied to clipboard

Fix #575: Replaced deprecated utils.Unmarshal and removed unused variables

Open ShivanshuGupta07 opened this issue 1 year ago • 3 comments

Description

This PR fixes #575 by replacing deprecated utils.Unmarshal with json.Unmarshal and removing unused variables from the codebase.

Notes for Reviewers

  • The changes involve updates to two specific files: config/provider/inmem.go and utils/kubernetes/crd.go.
  • Please verify that the replacement of utils.Unmarshal does not impact any other parts of the code that may rely on its specific behavior.

Signed commits

  • [x] Yes, I signed my commits.

ShivanshuGupta07 avatar Aug 25 '24 16:08 ShivanshuGupta07

Yay, your first pull request! :thumbsup: A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack. Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

welcome[bot] avatar Aug 25 '24 16:08 welcome[bot]

Thank you, @ShivanshuGupta07!

leecalcote avatar Sep 17 '24 05:09 leecalcote

@ShivanshuGupta07 merge conflicts

MUzairS15 avatar Sep 19 '24 10:09 MUzairS15

@MUzairS15, so no changes are required now?

ShivanshuGupta07 avatar Sep 27 '24 15:09 ShivanshuGupta07

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Nov 14 '24 01:11 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Dec 30 '24 14:12 stale[bot]

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.

stale[bot] avatar Jan 09 '25 23:01 stale[bot]