meshkit icon indicating copy to clipboard operation
meshkit copied to clipboard

Golang Lint Check Warnings

Open willcalcote opened this issue 1 year ago • 4 comments

Description Running make check produces the following warnings and suggestions:

validator/validate.go:17:2: var `schemaPath` is unused (unused)
	schemaPath      = "components.schemas"
	^
config/provider/inmem.go:57:9: SA1019: utils.Unmarshal is deprecated: Use Unmarshal from encoding package. TODO: Replace the usages from all projects. (staticcheck)
	return utils.Unmarshal(l.store[key], result)
	       ^
utils/kubernetes/crd.go:38:8: SA1019: utils.Unmarshal is deprecated: Use Unmarshal from encoding package. TODO: Replace the usages from all projects. (staticcheck)
	err = utils.Unmarshal(string(crdresult), &xcrd)

Expected Behavior All lint checks pass.

willcalcote avatar Aug 21 '24 18:08 willcalcote

Thanks for opening this issue. A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack.

welcome[bot] avatar Aug 21 '24 18:08 welcome[bot]

Hello @willcalcote I can work on this

khabdrick avatar Aug 21 '24 18:08 khabdrick

@leecalcote @khabdrick, Is there any update on this task? if not can I raise a PR.

ShivanshuGupta07 avatar Aug 25 '24 15:08 ShivanshuGupta07

@ShivanshuGupta07 you can take it up

khabdrick avatar Aug 25 '24 15:08 khabdrick