meshkit
meshkit copied to clipboard
Golang Lint Check Warnings
Description
Running make check produces the following warnings and suggestions:
validator/validate.go:17:2: var `schemaPath` is unused (unused)
schemaPath = "components.schemas"
^
config/provider/inmem.go:57:9: SA1019: utils.Unmarshal is deprecated: Use Unmarshal from encoding package. TODO: Replace the usages from all projects. (staticcheck)
return utils.Unmarshal(l.store[key], result)
^
utils/kubernetes/crd.go:38:8: SA1019: utils.Unmarshal is deprecated: Use Unmarshal from encoding package. TODO: Replace the usages from all projects. (staticcheck)
err = utils.Unmarshal(string(crdresult), &xcrd)
Expected Behavior All lint checks pass.
Thanks for opening this issue. A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack.
Hello @willcalcote I can work on this
@leecalcote @khabdrick, Is there any update on this task? if not can I raise a PR.
@ShivanshuGupta07 you can take it up