meshkit icon indicating copy to clipboard operation
meshkit copied to clipboard

Published 20 hours ago • verified publisher icon meshery

Added unit test for describe

Open ayushrakesh opened this issue 1 year ago • 9 comments

Added unit test for describe package in kubernetes via mock client

This PR fixes #287

Only added test for describe package, will soon add tests for expose and kompose

Signed commits

  • [x] Yes, I signed my commits.

ayushrakesh avatar Jun 28 '24 07:06 ayushrakesh

Yay, your first pull request! :thumbsup: A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack. Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

welcome[bot] avatar Jun 28 '24 07:06 welcome[bot]

@Aisuko That's what I can't able to understand ,why this is so, I have tried by removing my cloned copy and cloning it again, but it didn't worked. Can you help?

ayushrakesh avatar Jun 30 '24 06:06 ayushrakesh

@ayushrakesh declare a t.tempdir() to remove to test files or generated files after execution to keep things tidy, by the way does the test pass ?

Philip-21 avatar Jul 02 '24 22:07 Philip-21

@ayushrakesh declare a t.tempdir() to remove to test files or generated files after execution to keep things tidy, by the way does the test pass ?

@Philip-21 Sorry, but I can't understood what you said. Please can you explain once more? Test passed successfully by running make test.

ayushrakesh avatar Jul 03 '24 06:07 ayushrakesh

if tests pass successfully, then its fine. Use the temp.Dir() or os package to remove the generated test files for this unit test you wrote

Philip-21 avatar Jul 03 '24 22:07 Philip-21

@Philip-21 Pr is revised.

ayushrakesh avatar Jul 04 '24 06:07 ayushrakesh

@Philip-21 Please review my Pr.

ayushrakesh avatar Jul 10 '24 03:07 ayushrakesh

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Aug 25 '24 10:08 stale[bot]

Checking in... it has been awhile since we've heard from you on this issue. Are you still working on it? Please let us know and please don't hesitate to contact a MeshMate or any other community member for assistance.

        Be sure to join the community, if you haven't yet and please leave a :star: star on the project :smile:

github-actions[bot] avatar Aug 27 '24 04:08 github-actions[bot]